COMP: Build the release-5.4 examples against ITK release-5.4 - #480
Merged
hjmjohnson merged 1 commit intoSep 12, 2026
Merged
hjmjohnson merged 1 commit into
hjmjohnson merged 1 commit into
Conversation
This branch holds the examples that still build with ITK 5.x, so its CI must check out ITK's release-5.4 rather than main. Against ITK main these examples use the pre-namespace target names, which is not what a 5.4 user builds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S5zzoU6yyUwdLEvjM2s6iS
github-actions
Bot
added
type:Compiler
dzenanz
approved these changes
Sep 12, 2026
hjmjohnson
marked this pull request as ready for review
September 12, 2026 13:58
hjmjohnson
merged commit Sep 12, 2026
7cc2164
into
InsightSoftwareConsortium:release-5.4
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
release-5.4branch holds the examples that still build against ITK 5.x, but its CI checks out ITKmain. Pointitk-git-tagatrelease-5.4so the branch is tested against the ITK it targets.Why this branch exists and why the pin matters
mainnow builds only against ITK 6: every example linksITK::<Name>Moduleinterface targets, which ITK 5.x does not export.release-5.4was branched atb0679d89, the last commit that still configures and builds with ITK 5.x.Verified against ITK 5.4.7: that commit builds completely (0 failed targets, 346 executables) and its test suite passes 370 of 370. The commit immediately after it fails with 346 missing-target errors.
Without this pin,
release-5.4CI would build these ITK 5.x examples against ITKmain, which is neither what the branch is for nor what a 5.4 user compiles.