Repository navigation
Conversation
chfsx
requested review from
abrahammordev,
alex40724,
dsstrassner,
iszmais,
juanma1331 and
kergomard
October 23, 2026 21:28
Contributor
|
Hi @thojou please Look into this for Test. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ilExcelwrapsphpoffice/phpspreadsheet, but its API let two library details through:setCell()expected theDataType::TYPE_*constants of the library for explicit cell types, and its public methods threw the exceptions of the library. DataCollection therefore importedPhpOffice\PhpSpreadsheet\Cell\DataType, and Test, Exercise, Survey and DataCollection documentedPhpOffice\PhpSpreadsheet\Exceptionin their@throws. This PR gives Excel its own types for both. Same approach as #12266 (guzzlehttp/psr7), #12267 (pimple/pimple) and #12268 (dflydev/fig-cookies).Excel
ILIAS\Excel\CellType(string enum:STRING,NUMERIC,BOOL,FORMULA).ilExcel::setCell()acceptsCellType|string|null; strings keep working (e.g. for plugins) but are deprecated.ILIAS\Excel\ExcelException extends \RuntimeException.ilExceltranslates the exceptions of the library into it, keeping the original one as previous (constructor,loadFromFile(),addSheet(),setActiveSheet(),sendToClient(),writeToFile(),writeToTmpFile(),addLink(),mergeCells()). The library exception is a\RuntimeExceptionas well, so callers catching that keep working.ExcelTestTBDis active again asExcelTest(it was deactivated in 2024 because the library was missing) and gets tests for the exception translation and forCellType::STRING.Components
CellType::STRING.@throwsof DataCollection, Test, Exercise and Survey name\ILIAS\Excel\ExcelException; an unused import ofDataTypein Test is removed.Testing
[OK] All static artifacts are build!RootFolderTest, which only fails locally because of untracked files in the root folder of my checkout.components/ILIAS: green. php-cs-fixer on the changed files: clean.@kergomard for Excel, @iszmais for DataCollection, @alex40724 for Exercise, @abrahammordev @juanma1331 for Survey, @dsstrassner for Test.
If there are no objections, I will merge this before Coding Completed.