Repository navigation
Fix E2E payment locators after the Pay now / Pay later relabel - #1465
Merged
Merged
Conversation
The payment step now labels its tabs "Pay now" and "Pay later" and shows "Place order" when paying later, so /^Pay\b/ matched the tabs as well as the pay button and never matched on offline-only events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the E2E failures on
developafter #1460 (thee2e 1/2shards on #1461).#1460 relabelled the checkout payment step: the method tabs are now "Pay now" / "Pay later", and the submit button reads "Place order" when paying later. Two locators still matched on
/^Pay\b/:CheckoutPage.clickPay()(and its retry inpayWithStripeTestCard) now matched the two tabs as well as the "Pay $…" button, so both Stripe kitchen-sink specs failed with a strict mode violation. It now targets the button whose name is "Pay" followed by an amount.taxes-and-fees.spec.tsruns on an offline-only event, so the button reads "Place order" and the locator never matched; the test hung until the 60s timeout. It now clicksoffline-payment-button, asoffline-payment.spec.tsdoes.E2E-only change; no app code touched.
Testing
Rebuilt the hermetic e2e stack and ran, with Stripe test keys, every spec that goes through these helpers: taxes-and-fees, kitchen-sink (offline + Stripe), kitchen-sink-recurring (offline + Stripe), stripe-checkout, stripe-decline-retry, orders-refund, seat-stripe, embedded-widget. 15 passed.