Repository navigation
Spam-check archived events and custom email templates - #1463
Open
daveearley wants to merge 1 commit into
Open
daveearley wants to merge 1 commit into
daveearley wants to merge 1 commit into
Conversation
Archived events were never spam-checked: an event could go from draft straight to archived and send buyer emails with full content. Archived events are now checked like live ones, when they enter the status and when their content changes, and are demoted to pending review if flagged. Approving a flagged event restores the status it was demoted from (new event_spam_checks.previous_event_status column). Custom event and organizer email templates are now part of the checked content, as their Liquid source plus a render with sample data, and creating, updating or deleting a template triggers a re-check. The pending-review notice now goes to the account email instead of the unverified organizer email.
Contributor
✅ E2E smoke tests: Everything passed.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Archived events are spam-checked like live ones. Before this, only live events were checked. An event could go from draft straight to archived and send attendee and order emails with full content without ever being checked. Archived events are now checked:
events:recheck-spamA flagged archived event is demoted to pending review, just as a live one is.
Approve restores the original status. The check now records the status the event was demoted from, in a new nullable
event_spam_checks.previous_event_statuscolumn. Approving the event restores that status, so an approved archived event goes back to archived instead of being published.Custom email templates are checked. Every active event-level and organizer-level template goes into the checked content in two forms:
Only the source is part of the content hash, because the sample data includes a random order number. Creating, updating or deleting a template queues a re-check of the events it applies to.
The pending-review notice goes to the account email. It used to go to the organizer email, which is unverified free text.
Things to know
event_spam_checks.Testing