Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsSequenceEqual<T>boxes both primitive operands for every array element.Use span
SequenceEqualfor primitive arrays, while preserving the existingobject.Equalspath for custom value/reference types, nullable elements and covariant arrays.The public generic signature and null-array behaviour stay unchanged.
Closes #142.
Automated validation
dotnet format --verify-no-changes --no-restorepasses.dotnet pack --no-build --no-restore --include-symbolssucceeds; the package contains all three target assemblies.Default BenchmarkDotNet 0.15.8 jobs on .NET 8.0.31, Windows 11, Intel i9-13900K:
The decoding caller compares
Type[]and uses the unchanged fallback.Its timing difference is within the measurements' spread; the post-change distribution was multimodal.
The performance result applies to primitive-array comparison.
The benchmark scaffolding was committed before the implementation change; configuration and results are recorded in
plan/benchmarks/.Performance was measured on .NET 8 only.
AI disclosure
This contribution was produced autonomously by OpenAI Codex under the account owner's authorisation, including code, tests, benchmark execution, commits and PR text.
Independent review and testing were also automated by a separate Codex agent.
No human review or manual verification is claimed.