Skip to content

chore(gen): refresh API specs - #16

Merged
rmilyushkevich merged 1 commit into
mainfrom
claude/gen-refresh-20261020
Oct 20, 2026
Merged

rmilyushkevich merged 1 commit into
mainfrom
claude/gen-refresh-20261020

Conversation

@rmilyushkevich

Copy link
Copy Markdown
Contributor

Regenerated with go generate . on origin/main (97d05dd) against the live catalog. Spec hash f9e447f42c33. Supersedes the stale bot PR #13 (older hash). Nothing is hand-edited.

Command surface vs main

Added (13): chat-gpt-chat, facebook-profile, google-finance, google-flights-deals, google-scholar, google-scholar-cite, instagram-comments, tripadvisor-place, tripadvisor-reviews, tripadvisor-search, walmart-product, walmart-reviews, walmart-search

Removed (1): amazon-reviews (retired on purpose 2026-10-20; the live endpoint answers HTTP 400 "Invalid api response" and the base binary prints its deprecation notice)

Flags removed (each checked against the live API with the base binary):

  • google-events: --q --location --domain --gl --hl --htichips --start --uule dropped; now takes only --page-token (required). Old shape: --q returns HTTP 422 pageToken required, so the old call already fails today.
  • zillow-listing --listing-type: ignored by the API (byOwner in Austin returns all 5,623 for-sale results). Replaced by --listing-publish-options ownerPosted|agentListed.
  • google-maps-posts --next-page-token: ignored (a bogus token returns page 1, and the response has no pagination at all).
  • amazon-product --no-other-sellers: the API param otherSellers still exists, but its default flipped to false, so the generator no longer emits a negated flag. --other-sellers=false is the equivalent. Scripts using --no-other-sellers will get "unknown flag", so the next release is a minor bump.

Flags added:

  • glassdoor-listing: --date-posted --easy-apply-only --max-salary --min-rating --min-salary --radius --remote-only
  • google-events: --page-token
  • google-maps-place: --fetch-web-results
  • google-short-videos: --tbs
  • indeed-listing: --date-posted --next-page --remote-type --sponsored-only
  • web-scraping: --auto-mode

Defaults changed (help text only): example dates in airbnb/booking/google-flights/google-hotels move to Nov 2026; amazon-product --other-sellers false; indeed-listing --domain/--sort no default. Generated code sends a param only when its flag is set, so the request a user's command sends is unchanged. Also: credit costs in --help updated (e.g. amazon-product and zillow-listing 5 → 10), and amazon commands move to the E-commerce group.

Harness (head 6ba27e2)

  • go vet / build / test: pass
  • --help smoke on root + 67 commands, version, version --json, completion bash: pass
  • Live, head binary, 12/12 pass (exit 0, valid JSON, no error): canaries web-scraping, google-serp-light; new chat-gpt-chat, facebook-profile, google-finance, google-flights-deals, google-scholar, instagram-comments, tripadvisor-search, walmart-search; changed glassdoor-listing --remote-only, indeed-listing --date-posted. Not called (budget): google-scholar-cite, tripadvisor-place/-reviews, walmart-product/-reviews.
  • Removal checks, base binary: 4 calls (above).

Known, not fixed here: backticked words in flag descriptions show up as the flag's type in --help (e.g. --adults arrivalId). That's pflag's UnquoteUsage; the fix belongs in internal/gen, in a separate PR.


Generated by Claude Code

Regenerated from the live catalog (spec hash f9e447f42c33).
Adds 13 commands, drops amazon-reviews (retired upstream) and reshapes
google-events around --page-token.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VkPtq7Nyd8XbgFqYQWcYfm

@rmilyushkevich rmilyushkevich left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer review of 6ba27e2. I'm leaving a COMMENT review because GitHub doesn't let this account approve its own PR.

  • The generated files are exactly the output of go generate . on main at 97d05dd. Nothing is hand-edited.
  • Harness: vet/build/test pass; --help smoke passes on 67 commands; live 12/12 pass. The command-surface diff is in the description.
  • Hard rule 3: the amazon-reviews removal is confirmed (HTTP 400, retired on purpose). The google-events, zillow-listing and google-maps-posts flag removals are confirmed by live checks with the base binary. --no-other-sellers is dropped because the API's default flipped; --other-sellers=false is the equivalent. That breaks scripts that use the old flag, so the next release is a minor bump.
  • No findings in the generated code. The one known issue, backticks in flag help, is generator-side and gets its own PR.

Merging.


Generated by Claude Code

@rmilyushkevich
rmilyushkevich merged commit 3d4a638 into main Oct 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants