Repository navigation
Improve performance of vector data operations - #4781
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 27 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
timon-schelling
approved these changes
Oct 23, 2026
Performance Benchmark Results
|
…their shared rotation cache
…once, and find free points with a bitmap
…ernal geometry cache attribute
TrueDoctor
force-pushed
the
perf-improvements
branch
from
October 23, 2026 21:32
c6c394b to
a31c6f5
Compare
VimYoung
pushed a commit
to VimYoung/Graphite
that referenced
this pull request
Oct 26, 2026
* Keep taken IDs across Combine Paths concatenations so merging stays linear * Use loose control-box bounds for transformed click targets and reset their shared rotation cache * Compose group click targets from child layers instead of baking descendant copies * Share outline and click target geometry, build combined target paths once, and find free points with a bitmap * Share List element storage behind an Arc with copy-on-write * Cache vector contours as an item attribute shared by rendering and click targets * Cache mesh faces in the geometry cache alongside contours * Share click target geometry through the geometry cache and place it by transform * Address review feedback on click targets, bounds, naming, and the internal geometry cache attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vector::concattakes aTakenIdsset that carries over between calls, so merging N vectors is no longer O(N²).List: elements sit behind anArc, so clones share them until a write.Arc<TargetPath>plus a placement transform. Moving it only composes the transform. Bounds are cached per normalized linear part, so pan and zoom reuse one entry.Performance
Changes for a single edit (so with warm caches) for vello and svg. We don't have an equavalent test in the ci yet. this models the perf of creating a new shape on top of the artwork.
Ablation (Vello / SVG, each step compared with the previous one)
Listcopy-on-write