Skip to content

fix(compute): migrate debian-11 to debian-13, fix reservation cleanup , and update paths - #4506

Draft
angelcaamal wants to merge 8 commits into
mainfrom
fix/compute-samples-tests
Draft

angelcaamal wants to merge 8 commits into
mainfrom
fix/compute-samples-tests

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes b/573292786
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Oct 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default OS images used in Google Compute Engine samples and tests, upgrading Debian from version 11 to 13 and Ubuntu from 2004-lts to 2204-lts. It also simplifies network names in tests and adds conditional cleanup for reservation tests. However, in the reservation template test, setting the cleanup flag after the assertion can lead to leaked resources if the assertion fails. It is recommended to set this flag immediately after the creation command instead.

Comment thread compute/test/createReservationRegionalInstanceTemplate.test.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant