feat(feeds): add reaction write outcome fields - #350
Merged
JimmyPettersson85 merged 2 commits intoSep 21, 2026
Merged
Conversation
JimmyPettersson85
requested review from
oliverlaz and
szuperaz
as code owners
September 18, 2026 20:44
Adds outcome, previous_reaction_type and counter_delta to AddReactionResponse and AddCommentReactionResponse, from the v2 serverside spec (GetStream/chat#17241). Scoped to just these two interfaces rather than a full regeneration: a wholesale regen also pulls in every other spec change since the last refresh, which is a much wider surface than this needs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JimmyPettersson85
force-pushed
the
feature/feeds-1886-reaction-write-outcome
branch
from
September 19, 2026 09:20
72fa8e5 to
2e6b9c3
Compare
oliverlaz
approved these changes
Sep 21, 2026
JimmyPettersson85
deleted the
feature/feeds-1886-reaction-write-outcome
branch
September 21, 2026 14:14
szuperaz
pushed a commit
that referenced
this pull request
Sep 21, 2026
🤖 I have created a release *beep* *boop* --- ## [0.8.7](v0.8.6...v0.8.7) (2026-09-21) ### Features * **feeds:** add reaction write outcome fields ([#350](#350)) ([70d6cbb](70d6cbb)) * update to API spec v238.16.2 ([#348](#348)) ([11ceeda](11ceeda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds three new fields to
AddReactionResponseandAddCommentReactionResponse, from the v2 serverside spec:outcomestring—created|replaced|unchangedprevious_reaction_typestring?enforce_uniqueremovedcounter_deltanumber—0|1Backend PR: GetStream/chat#17241 (FEEDS-1886). With
enforce_unique=truethe previous reaction is replaced silently, and nothing in the response told the caller whether the reaction was new or a swap — so a customer keeping their own per-user reaction counter had to read before writing, or delete-then-add.Counting recipe:
add → outcome === 'created' ? +1 : 0;delete → 2xx ? -1 : 0.Scope
This is deliberately not a full regeneration.
src/genwas last refreshed on 2026-09-07, so a wholesale regen also pulls in every unrelated spec change since then —skip_own_followings,activity_marks, unity device fields, the user-interests endpoints, and additional optional params across the chat, common, moderation and video APIs. That was the first version of this PR and it failedchannel-types.test.ts.This version resets
src/gentomainand adds only the two reaction response interfaces: 30 insertions, 0 deletions, 1 file. Catching the rest up to the spec is worth doing, but as its own PR where a failure is attributable.Merge order
Merges before the backend, per the usual flow: SDKs merge and release first, then the chat repo bumps its pinned SDK versions, then GetStream/chat#17241 merges.
Generated from that PR's branch spec, so if its API surface changes during review this needs updating before release.
Testing
prettier --checkclean,tsc --noEmitclean.🤖 Generated with Claude Code