Repository navigation
qualify-declarations: default rates and quanta come from @openmixer/omx-contract (#93) - #98
Merged
Merged
Conversation
…er/omx-contract (#93) QUALIFY_RATES is the contract's ORACLE_FLOOR_RATES and the first of QUALIFY_QUANTA its RT_HARD_TARGET quantum, not restated lists. The package declares @openmixer/omx-contract as a dependency, and packaging/build.sh installs it beside the package so an RPM or DEB install resolves it. Tests: the lists equal the contract's, and the two declaration lines carry no 44100, 192000 or 128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93 (the operator chose the npm package as the source).
QUALIFY_RATES is now omx-contract's ORACLE_FLOOR_RATES and QUALIFY_QUANTA starts at RT_HARD_TARGET.quantum. @openmixer/omx-contract ^2.16.0 is a declared dependency; the generated tools/_declarations.py is unchanged (same values).
Packaging: npm pack does not carry dependencies, so packaging/build.sh copies the package into /node_modules/@openmixer/ beside plugin-qualify. I built it into a scratch dir and the installed dist loaded and printed the four rates. The RPM %files already takes the whole @Openmixer directory; the dry-run package jobs here show the rest.
Tests: the two lists equal the contract's values; the two declaration lines carry no 44100, 192000 or 128 literal (with a positive control). With the old declaration the second fails. Full suite, lint and the generated-declarations check pass.