Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
📝 Walkthrough
Merge Risk: 🟡 Moderate · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 32.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 40 functions across 19 files. (7 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request. Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled. Title check ✅ Passed The title clearly and concisely identifies the main change: adding IMAGE collector support to rn-davinci. The issue reference is relevant.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 32.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 40 functions across 19 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
tsdamas
changed the title
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (71.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
============================================
+ Coverage 71.25% 71.89% +0.64%
- Complexity 243 252 +9
============================================
Files 179 168 -11
Lines 24071 23200 -871
Branches 1037 826 -211
============================================
- Hits 17151 16680 -471
+ Misses 6764 6437 -327
+ Partials 156 83 -73
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
rodrigoareis
left a comment
rodrigoareis
left a comment
There was a problem hiding this comment.
Changes looks good to me. Just left a minor comment
| const hyperlinkUrl = imageCollector.hyperlinkUrl; | ||
| // Only http(s) URLs are opened; other schemes are ignored. | ||
| if (hyperlinkUrl && /^https?:\/\//i.test(hyperlinkUrl)) { | ||
| Linking.openURL(hyperlinkUrl).catch(() => {}); |
There was a problem hiding this comment.
I think this silently swallows the failure, so if the OS can't open the link (no handler installed, etc.) the user taps and nothing happens with no explanation. I would recommend log the error display a small message to the user.
There was a problem hiding this comment.
Good feedback. Addressed.
pingidentity-gaurav
left a comment
pingidentity-gaurav
left a comment
There was a problem hiding this comment.
LGTM great work
3 participants
Summary
Adds the DaVinci
IMAGEcollector to the React Native bridge. The display-only image collector (new in native DaVinci SDK 2.2) is serialized with its full payload (key,imageUrl,description, optionalhyperlinkUrl) on Android and iOS, classified asoutput_onlyin the JS helpers so it never contributesto
next()input, and rendered end-to-end in the sample app. Consumesdavinci:2.2.0-beta2on Android and the ping-ios-sdk develop checkout on iOS, whereImageCollectorships before the 2.2.0 pods publish.Changes
IMAGEthrough the public React Native API:ImageCollectortype mirroring the native 2.2 model:key,imageUrl, anddescriptiondefault to""when the server omits them;hyperlinkUrlis absent when the server omits it; optionalrawcarries the server-side field JSON via the shared raw lookup (both platforms' nativeImageCollector.idreturns the stablekey).imageDaVinciFieldKind,DaVinciNormalizedCollectorvariant, andoutput_onlyexecution mode (excluded from the submit payload;canSubmitunaffected).com.pingidentity.sdks:davincito2.2.0-beta2(first release withImageCollector).mapImageCollectoremits the documented defaults, omitshyperlinkUrlwhen null, and warns (no-silent-failure) when native init coerces a missing/non-stringimageUrlto"", naming the offending raw server value before emitting the default.mapImageCollectorwith the same payload shape, warning, andrawlookup (same contract as the Android 2.2 mapper).ImageCollectorresolves before the 2.2.0 podspec ships; package podspecs stay on 2.1.0.configurationErrorcase in the Journey, OIDC, and DaVinci error mappers (required to compile against the develop pods; re-verify at SDKS-5380).native-sdk-versionspre-commit.DaVinciImageFieldrenderer (image with caption fallback, following theDaVinciQrCodeFieldpattern; tappable hyperlink),IMAGEcase inDaVinciFieldRenderer, and image styles.IMAGErendering, README collector-table row, and integration coverage.output_only/imageclassification, payload exclusion,canSubmit/hasOutputOnlybehavior, and type-shape defaults.@ping-identity/rn-davinciminor changeset.Platform notes
2.2.0-beta2bump and the iOS develop pins are temporary (SDKS-5380): both converge on 2.2.0 when the pods publish, at which point the lefthook version check is re-enabled and the error-mapper TODOs re-verified.imageUrlorhyperlinkUrl— the SDK surfaces the values as received; the app renders the image and handles the hyperlink.hyperlinkUrlis omitted from the payload when the server omits it (nativenil/null), matching the optional TS field.Verification
Summary by CodeRabbit
IMAGEcollector.