Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 8f9c596 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Add the request header packages/journey-client/src/lib/journey.api.ts, .changeset/plenty-flies-tease.md |
prepareHeaders sets X-Requested-Platform from X_REQUESTED_PLATFORM. The changeset records the header and its CORS requirement. |
API report test timeouts
| Layer / File(s) | Summary |
|---|---|
Set API report timeouts tools/api-report/vitest.config.ts, tools/api-report/src/integration.spec.ts |
The Vitest configuration sets testTimeout and hookTimeout to 30,000 ms. A comment notes that the integration test runs API Extractor twice and can be slow in CI. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: vatsalparikh
Merge Risk: 
05b59
-
The Journey API requests include the requested-platform header, and the API-report timeout changes are limited to tests. Available evidence does not establish a harmful discovery-request omission, so no actionable merge-blocking risk remains.
Architecture risk: 
05b59
-
The change affects 2 systems.
Changed systems:
tools,packages/journey-clientArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — tools (service) was modified; 2 changed files map to changed impact.
- observed — packages/journey-client (library) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in packages/journey-client/src/lib/journey.api.ts: The utilities import now includes
X_REQUESTED_PLATFORM, used to set the request platform header. - observed — Modified behavior in packages/journey-client/src/lib/journey.api.ts:
prepareHeadersnow setsX-Requested-PlatformtoX_REQUESTED_PLATFORM. - observed — Modified behavior in tools/api-report/src/integration.spec.ts: Added a comment noting that the test runs api-extractor twice and can be slow in CI.
- observed — Modified behavior in tools/api-report/vitest.config.ts: Adds a comment about slow API Extractor invocations and sets the test and hook timeouts to 30,000 ms.
-
🚥 Pre-merge checks | ✅ 5
-
✅ Passed checks (5 passed)
-
Check name Status Explanation Title check ✅ Passed The title clearly identifies the missing X-Requested-Platform header fix in journey-client. Description check ✅ Passed The description includes both required sections, marks the Jira ticket as N/A, and states the change. The changeset is also present in the pull request. Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
-
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
|
View your CI Pipeline Execution ↗ for commit 8f9c596
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
SteinGabriel
approved these changes
Sep 29, 2026
| headers.set('Accept-API-Version', 'protocol=1.0,resource=2.1'); | ||
| headers.set('Content-Type', 'application/json'); | ||
| headers.set('X-Requested-With', REQUESTED_WITH); | ||
| headers.set('X-Requested-Platform', 'javascript'); |
Contributor
There was a problem hiding this comment.
Should we be using the SDK utils property here like we do for requested with?
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
===========================================
+ Coverage 18.07% 96.29% +78.22%
===========================================
Files 155 1 -154
Lines 24398 81 -24317
Branches 1203 17 -1186
===========================================
- Hits 4410 78 -4332
+ Misses 19988 3 -19985 🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/recognize
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Contributor
|
Deployed a33ff05 to https://ForgeRock.github.io/ping-javascript-sdk/pr-848/a33ff05e0d226c14adb832708265ad0e331fe52a branch gh-pages in ForgeRock/ping-javascript-sdk |
Contributor
Interface Mapping Out of DateThe Drift reportTo fix, run: pnpm mapping:generateThen commit the updated |
Contributor
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-10.3 KB, -100.0%) 📊 Minor Changes📈 @forgerock/journey-client - 95.4 KB (+0.0 KB) ➖ No Changes➖ @forgerock/iframe-manager - 3.2 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 5, 2026 15:19
306e89f to
05b594e
Compare
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 13, 2026 21:00
05b594e to
1fcff77
Compare
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 21, 2026 18:00
1fcff77 to
8dc21e4
Compare
api-extractor invocations can be slow in CI environments. The 'should handle multiple entry points' test was timing out at the default 5000ms. Set testTimeout and hookTimeout to 30000ms in vitest.config.ts to match the actual test duration.
ryanbas21
force-pushed
the
x-requested-platform
branch
from
October 30, 2026 19:00
8dc21e4 to
8f9c596
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
N/A
Description
X-requested platform header missing on journey-client
Summary by CodeRabbit
X-Requested-Platformheader identifying the JavaScript platform.X-Requested-Platformheader so requests can be accepted.