Conversation
…ith consumer types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Follow-up to #94. Based on
feat/experimentation; retarget tomainonce that merges.The client now remembers which identity the stored flags were fetched for (
nullfor environment flags,reset()and a fresh process). Lookups that take auserfetch from the API only when that identity differs from the stored one, and read storage otherwise. An explicitreloadstill wins.getExperimentFlag(user:)no longer hits/identitieson every call; same identity as the last fetch is served from storage, a different identity is fetched. Exposures keep the guarantee from feat: surface experiment metadata on flags and add event tracking #94: never attributed against another identity's assignment.hasFeatureFlag,isFeatureFlagEnabledandgetFeatureFlagValueshare the same rule through_getFlagByName. Previously auserdifferent from the last fetch silently returned the previous identity's flags from storage; now it fetches once. Same identity or nouser: unchanged, no request.Behaviour change to the three existing methods only on the path that returned the wrong identity's flags.
How did you test this code?
flutter analyzeclean,flutter test165 passing. New cases: same identity makes no request; environment flags overwriting storage trigger a fetch for the cached identity;hasFeatureFlagwith a switched identity fetches once and then reads storage.🤖 Generated with Claude Code