Repository navigation
fix: workerd last-event-id encoding - #370
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted workaround is covered across native and custom fetch paths, with affected runtime limitations documented.
0 open findings
What changed in this PR
Fixes double-encoding of non-ASCII Last-Event-ID values in Cloudflare Workers while documenting WebKit limitations.
Changes:
- Passes Unicode IDs directly to workerd’s native
fetch. - Expands UTF-8 reconnection tests and WebKit-specific handling.
- Documents runtime limitations and release impact.
| File | Description |
|---|---|
src/EventSource.ts |
Adds workerd-specific header handling. |
test/client.test.ts |
Expands Unicode ID coverage. |
test/helpers/env.ts |
Exposes WebKit test context. |
vitest.browser.config.ts |
Identifies Playwright WebKit tests. |
vitest.ios.config.ts |
Identifies iOS Safari tests. |
README.md |
Documents WebKit and Workers behavior. |
CONTRIBUTING.md |
Documents runtime-test policy. |
.changeset/fix-workerd-event-id-encoding.md |
Records the patch release change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workerd handles outgoing headers incorrectly: cloudflare/workerd#7734
This PR attempts to fix this by passing the bytes verbatim if user agent tells us we're on cloudflare workers.
Also documents utf-8
last-event-idlimitation on webkit: there's no way (that I've found) to make the bytes received by the server end up correctly sent. I'm creating an issue for this in the webkit bug tracker.