Conversation
Brings the lint gems current (rubocop 1.70.0 -> 1.88.2, standard 1.44.0 -> 1.56.0) and fixes the one offense the upgrade surfaces.
dpep
marked this pull request as draft
September 18, 2026 01:25
dpep
marked this pull request as ready for review
September 18, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request brings the lint gems current — rubocop 1.70.0 → 1.88.2 and standard 1.44.0 → 1.56.0 — and fixes the one offense the upgrade surfaces.
TargetRubyVersionand thestandard: config/ruby-3.0.ymlinherit are deliberately left alone, so this is a tool bump only and no new cops are gated on the Ruby target.Background 📜
Both gems are declared unversioned in the
Gemfile, so this is aGemfile.lockupdate. The dependency changes are confined to rubocop's own tree:rubocop-ast,rubocop-minitest,rubocop-performance,standard-performance,parser,json,ast,parallel,regexp_parser,language_server-protocolandunicode-display_width.standard1.56.0 requiresrubocop ~> 1.88.0, which is what pulls rubocop forward.The upgrade reports exactly one offense,
Style/RedundantArrayFlatteninViteRuby::CLI::FileUtils.write:It is a true positive —
Array#joinalready joins nested arrays recursively, so flattening first is redundant.The Fix 🔨
By dropping the
flatten, and adding a test that pins the nested-content contract ofwrite.The cop is marked
Safe: false, sorubocop -askips it andrubocop -Awas not used; the one-line change is applied by hand.Verified rather than assumed:
test_write_nested_contentpasses both with and without theflatten, so it pins the documented behaviour ofwriterather than the implementation.nilelements, an empty list and a hash.bundle exec rubocopis clean: 101 files, no offenses (it reported 1 before the fix).bin/rake testpasses on Ruby 4.0.6: 115 tests, 437 assertions, 0 failures.Two pre-existing notices now surface with the newer rubocop, left out to keep this focused:
Naming/PredicateNamehas been renamed toNaming/PredicatePrefix, andrubocop-performance/rubocop-minitestnow preferplugins:overrequire:. Both are warnings only and the run still exits 0. Happy to fold either in, or follow up separately, whichever you prefer.