Skip to content

Make the pre-push check run on the shell macOS ships #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdbertChan merged 1 commit into from
Oct 13, 2026
Merged

Make the pre-push check run on the shell macOS ships #1388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/git-hooks/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ while read -r local_ref local_sha remote_ref remote_sha; do
echo "pre-push: UNCHECKED: git diff $diff_from $local_sha failed for $local_ref; $bypass" >&2
exit 1
fi
mapfile -d '' files <"$names"
files=(); while IFS= read -r -d '' _path; do files+=("$_path"); done <"$names"
if [[ ${#files[@]} -eq 0 ]]; then
continue
fi
Expand All @@ -173,7 +173,7 @@ while read -r local_ref local_sha remote_ref remote_sha; do
if old_diff_from=$(git merge-base "$base_ref" "$remote_sha" 2>/dev/null); then
old_names=$(mktemp)
if git diff --name-only -z "$old_diff_from" "$remote_sha" >"$old_names"; then
mapfile -d '' old_files <"$old_names"
old_files=(); while IFS= read -r -d '' _path; do old_files+=("$_path"); done <"$old_names"
if [[ ${#old_files[@]} -eq 0 ]]; then
old_rc=0
else
Expand All @@ -182,7 +182,7 @@ while read -r local_ref local_sha remote_ref remote_sha; do
if [[ $old_rc -eq 1 ]]; then
delta_names=$(mktemp)
if git diff --name-only -z "$remote_sha" "$local_sha" >"$delta_names"; then
mapfile -d '' delta_files <"$delta_names"
delta_files=(); while IFS= read -r -d '' _path; do delta_files+=("$_path"); done <"$delta_names"
if [[ ${#delta_files[@]} -eq 0 ]]; then
continue
fi
Expand Down
Loading