Repository navigation
Drop the lesson-router comments that failed the comment gate. - #1330
Merged
Conversation
The boundary-parser allow mark stays, and the comment checker treats that mark as a machine directive so the two gates agree. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: I0a048d4d387df53de81d2638521a5198de499b36
Owner
Author
|
This pull request is part of a Mergify stack:
|
6 tasks done
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 74537e1e-af6f-4a23-97d5-d79b30cbe415) |
EdbertChan
merged commit Oct 11, 2026
cfbdf1a
into
stack/EdbertChan/reflect/lesson-route-already-covered/route-restated-existing-rules-already-covered--bb2d3e90
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lesson router failed its check because the new file explained itself in comments. Those comments are gone. The mark that tells the text checker a line is a real parser stays, and the comment checker now treats that mark as a machine instruction.
Review Claim
A lesson router can keep the mark that allows a text parser, and the comment checker accepts that mark.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
Prose comments stay banned. Only the existing allow mark for a text parser is recognized, beside the marks the checker already allows. This does not merge.
Non-goals
Slice Rationale
The router and the comment checker change together. Leaving the mark while the checker rejects it keeps the check red. Deleting the mark makes the text checker warn on the parser lines.
Measured
Command:
python3 scripts/ci/check_no_new_comments.py --base origin/mainfail 20 new comment line(s); comments are banned in codeok no new commentsTest Plan
Test Plan
python3 scripts/ci/check_hook_test_coverage.py engine/hooks/no-comments—check_hook_test_coverage: OK (1 hook(s) checked)python3 scripts/ci/check_skill_test_coverage.py --base HEAD~1 --head HEAD—ok skill test coverageruff check --select E9,Fon the four changed files —All checks passed!python3 scripts/ci/check_skills_three_harnesses.py—ok skills four-harness checkpython3 scripts/ci/check_ecosystem_boundaries.py—ok ecosystem boundariespython3 scripts/ci/check_skill_file_refs.py—ok skill file refspython3 scripts/ci/check_skill_trigger_mechanism.py—ok skill trigger mechanismpython3 scripts/ci/check_skill_trigger_policy.py—ok skill trigger policypython3 scripts/ci/check_subagent_scope_contract.py—ok subagent scope contractpython3 scripts/ci/check_no_new_comments.py --base origin/main—ok no new commentspython3 -m unittest engine.hooks.no-comments.tests.test_hooks.TestAllows.test_allows_directives_and_shebang engine.skills.reflect.scripts.tests.test_lesson_route -q—Ran 11 tests/OKRevert Plan
Revert Plan
Revert this commit. The comment checker again rejects the parser allow mark, and the router file is back to the prose comments that failed the check.