Skip to content

fix: serve the refreshed icon at the old path - #82

Open
lmjabreu wants to merge 2 commits into
mainfrom
luis/restore-old-icon-path
Open

lmjabreu wants to merge 2 commits into
mainfrom
luis/restore-old-icon-path

Conversation

@lmjabreu

@lmjabreu lmjabreu commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Overview

#79 moved the icon to comms-cli_512px.png and deleted icons/comms-cli.png. Every tdc release so far (latest is 3.6.0) sends that old raw GitHub URL as logo_uri when it registers a client, and Todoist stores the URL once and never refreshes it. So every Comms CLI client registered to date, and every new one until a release ships the new LOGO_URI, shows a broken consent-screen icon. This puts the refreshed icon back at the old path (same bytes as comms-cli_512px.png), so all of them show the new icon. The fix: title cuts a release that ships the new LOGO_URI from #79.

icons/comms-cli.png has to stay permanently: clients that stored this URL keep it for good.

Reference

Follows #79.

Changelog

Fix the missing consent-screen icon for clients registered by older versions.

Test plan

  1. Open https://raw.githubusercontent.com/doist/comms-cli/main/icons/comms-cli.png on main before this is merged.
    • It returns 404.
  2. Open the same URL after this is merged.
    • The refreshed Comms CLI icon loads.
  3. Run tdc auth login with an existing config, then again with a fresh config after the release.
    • Both consent screens show the new icon.

Demo

BeforeAfter

lmjabreu and others added 2 commits October 15, 2026 14:59
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@lmjabreu lmjabreu changed the title fix: restore the old CLI icon path fix: serve the refreshed icon at the old path Oct 16, 2026
@lmjabreu
lmjabreu marked this pull request as ready for review October 16, 2026 11:47
@lmjabreu
lmjabreu requested review from a team, craigcarlyle and gnapse and removed request for a team and craigcarlyle October 16, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants