Conversation
| workflow_name, | ||
| ]); | ||
|
|
||
| let workflow = reqwest::Client::new() |
There was a problem hiding this comment.
suggest to use the public static client if possible:
There was a problem hiding this comment.
CLIENT is currently declared as pub(self) in graphql/mod.rs, so it isn't accessible from subscription.rs. Should I widen its visibility and reuse it here?
| import React from "react"; | ||
|
|
||
| export function getTaskStatusIcon(status: TaskStatus, size: number = 25) { | ||
| const pulse = keyframes` |
There was a problem hiding this comment.
Is this intentional? These look like style changes that are unrelated to the problem (fixing logs for completed workflows).
There was a problem hiding this comment.
Intentional. I added the running status indicator to make it clearer to users that a task is still active while logs may not yet be available. That said, it's not strictly required for the completed-workflow log fix, so I'm happy to move it into a separate PR if you'd prefer to keep this change focused.
| }} | ||
| data-testid="handle-target" | ||
| onClick={(event) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Is this intentional? This seems unrelated to the logs.
There was a problem hiding this comment.
Intentional. I found that task selection did not reliably respond while a workflow was running. This change ensures clicks are handled consistently so users can select a task and view its logs.
| }} | ||
| data-testid="handle-source" | ||
| onClick={(event) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Same as above. I found that clicks on running workflow tasks were not consistently handled. This change ensures task selection works reliably while the workflow is running so users can access task logs.
2 participants
Return “Log not available” immediately for completed workflows without archived logs AP-1319
Summary
Improve log handling for completed workflows where archived task logs are unavailable.
Previously, when a user selected a task in a completed workflow that had already been archived, the frontend would repeatedly attempt to retrieve logs, displaying "Waiting for logs" and retrying up to 10 times before eventually showing "Log not available".
This change avoids unnecessary retries when it is already known that a completed workflow has no archived logs available.