Skip to content

fix(tests): remove obsolete dodal data_session fixture - #1692

Open
ZohebShaikh wants to merge 2 commits into
mainfrom
fix-dodal-data-session-fixture
Open

ZohebShaikh wants to merge 2 commits into
mainfrom
fix-dodal-data-session-fixture

Conversation

@ZohebShaikh

@ZohebShaikh ZohebShaikh commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

dodal 3.0.2 removed dodal.plan_stubs.data_session (DiamondLightSource/dodal#2201). The path_provider fixture in tests/unit_tests/worker/test_task_worker.py patched get_path_provider in that module, so with 3.0.2 test_worker_and_data_events_produce_in_order errors at setup:

AttributeError: module 'dodal.plan_stubs' has no attribute 'data_session'

Nothing uses that module any more, so this removes the fixture and raises the dls-dodal floor (dev group and demo extra) from >=1.69.0 to >=3.0.2, so the tests never run against a dodal that still has the module. The lock moves to dodal 3.0.2 (ophyd-async 0.21.2 → 0.21.3 comes with it).

just unit: 1035 passed, 1 skipped.

🤖 Generated with Claude Code

dodal 3.0.2 removed dodal.plan_stubs.data_session, so patching
get_path_provider there fails test setup with AttributeError. Nothing
uses that module any more, so drop the fixture and bump the lock to
dodal 3.0.2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ZohebShaikh
ZohebShaikh requested a review from a team as a code owner October 6, 2026 15:05
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.34%. Comparing base (8160397) to head (9699b20).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          46       46           
  Lines        3665     3665           
=======================================
  Hits         3531     3531           
  Misses        134      134           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Older dodal still ships plan_stubs.data_session, which the tests no
longer stub out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants