Repository navigation
Grids: type search, row dragging, pager - #35941
Merged
Merged
Conversation
anna-shakhova
changed the title
anna-shakhova
force-pushed
the
type_search_main
branch
from
October 26, 2026 14:17
b045434 to
a99bee1
Compare
anna-shakhova
commented
Oct 27, 2026
| } | ||
| } | ||
|
|
||
| private getPager() { |
Contributor
Author
There was a problem hiding this comment.
It was used in tests only. Replaced with getInstance in tests
anna-shakhova
marked this pull request as ready for review
October 27, 2026 11:08
pharret31
previously approved these changes
Oct 27, 2026
bit-byte0
reviewed
Oct 27, 2026
Comment on lines
+46
to
+48
| Base: ModuleType<RowsView & ColumnFixingRowsViewExtension>, | ||
| ): ModuleType< | ||
| RowsView & ColumnFixingRowsViewExtension |
Contributor
There was a problem hiding this comment.
RowsView & ColumnFixingRowsViewExtension is spelled out three times in this file (also the cast in onRowPrepared). would a named alias in column_fixing/types.ts read better, the way CellBasedEditingController is used in extender signatures?
Comment on lines
+33
to
+35
| ): ModuleType< | ||
| DataController & SearchDataControllerExtension | ||
| > => class SearchDataControllerExtender extends base { |
Contributor
There was a problem hiding this comment.
SearchDataController already exists in types.ts - maybe use it here as ModuleType<SearchDataController>? then the SearchDataControllerExtension import isn't needed in this file
bit-byte0
previously approved these changes
Oct 27, 2026
anna-shakhova
dismissed stale reviews from bit-byte0 and pharret31
via
October 27, 2026 11:38
0ef3f43
anna-shakhova
force-pushed
the
type_search_main
branch
from
October 27, 2026 11:38
d436682 to
0ef3f43
Compare
anna-shakhova
enabled auto-merge
October 27, 2026 11:42
bit-byte0
approved these changes
Oct 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.