Repository navigation
update discrete aggregation demo - #35834
Open
DuckTieCorpMember wants to merge 2 commits into
Open
DuckTieCorpMember wants to merge 2 commits into
DuckTieCorpMember wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking defects were identified; the remaining documentation correction is minor.
1 open issue
What changed in this PR
Enhances DevExtreme’s Discrete Points Aggregation demos consistently across Angular, React, Vue, and jQuery.
Changes:
- Adds aggregation toggling and Average, Maximum, and Minimum selection.
- Adds overlapping MAX reference bars and more varied sample data.
- Styles the new options panels.
Paths below are relative to apps/demos/Demos/Charts/DiscretePointsAggregation/.
| File | Description |
|---|---|
| Vue/data.ts | Updates values and adds reference-series data. |
| Vue/App.vue | Adds controls, reference bars, and styling. |
| ReactJs/styles.css | Styles the options panel. |
| ReactJs/data.js | Updates values and adds reference-series data. |
| ReactJs/App.js | Adds controls and reference bars. |
| React/styles.css | Styles the options panel. |
| React/data.ts | Updates values and adds reference-series data. |
| React/App.tsx | Adds typed controls and reference bars. |
| jQuery/styles.css | Styles the options panel. |
| jQuery/index.js | Configures controls and reference bars. |
| jQuery/index.html | Adds control containers. |
| jQuery/data.js | Updates values and adds reference-series data. |
| Angular/app/app.service.ts | Supplies updated data and reference series. |
| Angular/app/app.component.ts | Adds control state and series customization. |
| Angular/app/app.component.html | Binds aggregation controls. |
| Angular/app/app.component.css | Styles the options panel. |
Review effort: Balanced
| aggregation: { | ||
| enabled: true, | ||
| method: 'sum', | ||
| method: 'avg', |
| const year = isMaxSeries ? seriesName.slice(0, -MAX_SUFFIX.length) : seriesName; | ||
|
|
||
| return { | ||
| barOverlapGroup: year, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the Discrete Points Aggregation chart demos. The main focus is to add user controls for toggling aggregation and selecting the aggregation method, as well as adding a MAX value bar as a reference to make aggregation changes more visible.