You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Angular: zoneless tests and core components changes - #35749
PR applies changes for supporting Angular zoneless mode (default for new Angular 21+ apps). Zone-based apps keep working as before; no breaking changes.
The notification is still inside if (emitter.observers.length), so callback-only nested widgets are missed. For example, a toolbar button configured through items[].options.onClick can have no click emitter subscribers. Core _createActionByOption invokes fireEvent before executing the option callback separately (core/widget/component.ts:466–470); updating a plain host field in that callback does not notify Angular, leaving a zoneless view stale unless another change-detection trigger occurs. Cover user-configured option callbacks in the notification path and add a zoneless regression test, while preserving suppression for widget-internal callbacks.
The new notifications only run when the emitter has observers. A handler configured with button.instance.option('onClick', handler) runs separately as an action callback, so an otherwise unbound button executes it but leaves plain host fields it changes stale in a zoneless app. Also notify for configured public event callbacks and cover this registration path with a zoneless test.
This unconditionally marks the view even when fieldDataChanged comes from ngZone.runOutsideAngular(() => form.instance.updateData(...)) with no Angular event bindings. In zone-based Angular 21 apps, markForCheck() schedules change detection even outside the zone, so background form updates that previously avoided change detection now refresh the application. Please apply the same canMarkForCheck(ngZone) guard used by NgEventsStrategy, or restrict this fallback to zoneless mode, and cover the outside-zone case.
Test scroll position changes through the widget API
Dispatching a scroll event does not change the container's scroll position, so this test never moves the virtual viewport. The virtual-scrolling handler skips viewport updates when the offset is unchanged, leaving row loading and page changes untested. Scroll through the widget API and assert that the visible row range changes before checking the change-detection count.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Nested widget event strategies still lack change-detection notification, allowing application handlers to leave zoneless views stale; this path needs a fix and regression coverage.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because option-registered callbacks can bypass zoneless change-detection notification, leaving updated state unreflected in bindings.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because configured widget callbacks without event subscribers can bypass zoneless change-detection notification and leave displayed state stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR applies changes for supporting Angular zoneless mode (default for new Angular 21+ apps). Zone-based apps keep working as before; no breaking changes.