Repository navigation
Data source adapter, virtual data loader, TreeList data controller and data source adapter - remove m_ prefix - #35612
Open
bit-byte0 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The mechanical renames are consistent, and no stale references to the renamed grid modules remain.
0 open findings
What changed in this PR
Removes legacy m_ prefixes from grid data-loading modules and updates all affected imports.
Changes:
- Renames core data-source adapter, utility, and virtual-loader modules.
- Renames TreeList data-controller and adapter modules.
- Updates consumers and tests to use the new paths.
| File | Description |
|---|---|
tree_list/m_widget_base.ts |
Updates data-controller import. |
tree_list/m_virtual_scrolling.ts |
Updates adapter imports. |
tree_list/editing/m_editing.ts |
Updates TreeList controller import. |
tree_list/data_source/data_source_controller.ts |
Updates TreeList adapter imports. |
tree_list/data_source_adapter/data_source_adapter.ts |
Renamed adapter using the new core path. |
tree_list/data_source_adapter/data_source_adapter.test.ts |
Updates tested module path. |
tree_list/data_controller/data_controller.ts |
Renamed TreeList data controller. |
tree_list/columns_controller.ts |
Updates core adapter import. |
grid_core/virtual_scrolling/m_virtual_scrolling.ts |
Updates adapter import. |
grid_core/virtual_scrolling/m_virtual_scrolling_core.ts |
Updates virtual-loader import. |
grid_core/virtual_data_loader/virtual_data_loader.ts |
Renamed virtual data loader. |
grid_core/m_utils.ts |
Updates adapter import. |
grid_core/data_source/data_source_controller.ts |
Updates adapter import. |
grid_core/data_source/__tests__/data_source_controller.test.ts |
Updates test import. |
grid_core/data_source_adapter/types.ts |
Updates local adapter import. |
grid_core/data_source_adapter/provider.ts |
Updates local adapter import. |
grid_core/data_source_adapter/data_source_adapter.ts |
Renamed adapter and utility import. |
grid_core/data_source_adapter/data_source_adapter_utils.ts |
Renamed adapter utilities. |
grid_core/data_source_adapter/custom_loader.ts |
Updates utility import. |
grid_core/data_controller/data_controller.ts |
Updates adapter import. |
grid_core/columns_controller/columns_controller.ts |
Updates adapter import. |
grid_core/columns_controller/columns_controller_utils.ts |
Updates adapter import. |
grid_core/ai_column/controllers/ai_column_controller.ts |
Updates adapter import. |
data_grid/summary/m_summary.ts |
Updates adapter import. |
data_grid/grouping/m_grouping.ts |
Updates adapter import. |
data_grid/grouping/m_grouping_expanded.ts |
Updates adapter import. |
data_grid/grouping/m_grouping_collapsed.ts |
Updates adapter import. |
data_grid/data_source_adapter.ts |
Updates core adapter import. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed
m_prefix from data source adapter, virtual data loader and TreeList data controller and data source adapter filesHow
Rename only, imports updated