Skip to content

fix(Lightning, RippleGrid): cancel the render loop on cleanup #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHDev merged 1 commit into from
Aug 14, 2026
Merged

fix(Lightning, RippleGrid): cancel the render loop on cleanup #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/content/Backgrounds/Lightning/Lightning.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ const Lightning = ({ hue = 230, xOffset = 0, speed = 1, intensity = 1, size = 1
const uIntensityLocation = gl.getUniformLocation(program, 'uIntensity');
const uSizeLocation = gl.getUniformLocation(program, 'uSize');

let animationFrameId;
const startTime = performance.now();
const render = () => {
resizeCanvas();
Expand All @@ -167,11 +168,12 @@ const Lightning = ({ hue = 230, xOffset = 0, speed = 1, intensity = 1, size = 1
gl.uniform1f(uIntensityLocation, intensity);
gl.uniform1f(uSizeLocation, size);
gl.drawArrays(gl.TRIANGLES, 0, 6);
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resizeCanvas);
};
}, [hue, xOffset, speed, intensity, size]);
Expand Down
6 changes: 4 additions & 2 deletions src/content/Backgrounds/RippleGrid/RippleGrid.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ void main() {
}
resize();

let animationFrameId;
const render = t => {
uniforms.iTime.value = t * 0.001;

Expand All @@ -215,13 +216,14 @@ void main() {
uniforms.mousePosition.value = [mousePositionRef.current.x, mousePositionRef.current.y];

renderer.render({ scene: mesh });
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};

requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

const container = containerRef.current;
return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resize);
if (mouseInteraction && container) {
container.removeEventListener('mousemove', handleMouseMove);
Expand Down
6 changes: 4 additions & 2 deletions src/tailwind/Backgrounds/Lightning/Lightning.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ const Lightning = ({ hue = 230, xOffset = 0, speed = 1, intensity = 1, size = 1
const uIntensityLocation = gl.getUniformLocation(program, 'uIntensity');
const uSizeLocation = gl.getUniformLocation(program, 'uSize');

let animationFrameId;
const startTime = performance.now();
const render = () => {
resizeCanvas();
Expand All @@ -166,11 +167,12 @@ const Lightning = ({ hue = 230, xOffset = 0, speed = 1, intensity = 1, size = 1
gl.uniform1f(uIntensityLocation, intensity);
gl.uniform1f(uSizeLocation, size);
gl.drawArrays(gl.TRIANGLES, 0, 6);
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resizeCanvas);
};
}, [hue, xOffset, speed, intensity, size]);
Expand Down
6 changes: 4 additions & 2 deletions src/tailwind/Backgrounds/RippleGrid/RippleGrid.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ void main() {
}
resize();

let animationFrameId;
const render = t => {
uniforms.iTime.value = t * 0.001;

Expand All @@ -214,13 +215,14 @@ void main() {
uniforms.mousePosition.value = [mousePositionRef.current.x, mousePositionRef.current.y];

renderer.render({ scene: mesh });
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};

requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

const container = containerRef.current;
return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resize);
if (mouseInteraction && container) {
container.removeEventListener('mousemove', handleMouseMove);
Expand Down
6 changes: 4 additions & 2 deletions src/ts-default/Backgrounds/Lightning/Lightning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ const Lightning: React.FC<LightningProps> = ({ hue = 230, xOffset = 0, speed = 1
const uIntensityLocation = gl.getUniformLocation(program, 'uIntensity');
const uSizeLocation = gl.getUniformLocation(program, 'uSize');

let animationFrameId: number;
const startTime = performance.now();
const render = () => {
resizeCanvas();
Expand All @@ -175,11 +176,12 @@ const Lightning: React.FC<LightningProps> = ({ hue = 230, xOffset = 0, speed = 1
gl.uniform1f(uIntensityLocation, intensity);
gl.uniform1f(uSizeLocation, size);
gl.drawArrays(gl.TRIANGLES, 0, 6);
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resizeCanvas);
};
}, [hue, xOffset, speed, intensity, size]);
Expand Down
6 changes: 4 additions & 2 deletions src/ts-default/Backgrounds/RippleGrid/RippleGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ void main() {
}
resize();

let animationFrameId: number;
const render = (t: number) => {
uniforms.iTime.value = t * 0.001;

Expand All @@ -230,12 +231,13 @@ void main() {
uniforms.mousePosition.value = [mousePositionRef.current.x, mousePositionRef.current.y];

renderer.render({ scene: mesh });
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};

requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resize);
if (mouseInteraction && containerRef.current) {
containerRef.current.removeEventListener('mousemove', handleMouseMove);
Expand Down
6 changes: 4 additions & 2 deletions src/ts-tailwind/Backgrounds/Lightning/Lightning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const Lightning: React.FC<LightningProps> = ({ hue = 230, xOffset = 0, speed = 1
const uIntensityLocation = gl.getUniformLocation(program, 'uIntensity');
const uSizeLocation = gl.getUniformLocation(program, 'uSize');

let animationFrameId: number;
const startTime = performance.now();
const render = () => {
resizeCanvas();
Expand All @@ -174,11 +175,12 @@ const Lightning: React.FC<LightningProps> = ({ hue = 230, xOffset = 0, speed = 1
gl.uniform1f(uIntensityLocation, intensity);
gl.uniform1f(uSizeLocation, size);
gl.drawArrays(gl.TRIANGLES, 0, 6);
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resizeCanvas);
};
}, [hue, xOffset, speed, intensity, size]);
Expand Down
6 changes: 4 additions & 2 deletions src/ts-tailwind/Backgrounds/RippleGrid/RippleGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ void main() {
}
resize();

let animationFrameId: number;
const render = (t: number) => {
uniforms.iTime.value = t * 0.001;

Expand All @@ -229,12 +230,13 @@ void main() {
uniforms.mousePosition.value = [mousePositionRef.current.x, mousePositionRef.current.y];

renderer.render({ scene: mesh });
requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);
};

requestAnimationFrame(render);
animationFrameId = requestAnimationFrame(render);

return () => {
cancelAnimationFrame(animationFrameId);
window.removeEventListener('resize', resize);
if (mouseInteraction && containerRef.current) {
containerRef.current.removeEventListener('mousemove', handleMouseMove);
Expand Down