Repository navigation
add a bunch of basic unit tests - #5942
Merged
Merged
Conversation
unit tests for dfhack lua library code
two of these test something that we don't currently implement but might someday the others are incorrect and/or redundant with existing tests
correct basic test remove test of unimplemented default_value functionality
rewrite some tests for specifics of dfhack's libs comment out some that are either pointless or cannot be tested fix syntax on some
SilasD
approved these changes
Sep 20, 2026
SilasD
left a comment
SilasD
left a comment
Contributor
There was a problem hiding this comment.
All good. I'm happy with this. decent coverage and should run fast.
it doesn't excercise everything but really, no test suite can.
I'd like to extend this, test some of the string extensions with Lua's poor-man regexps and some of the specialty function handling with parameters given to the called functions. maybe someday. I'll put it on my list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unit tests for dfhack lua library code