Skip to content

plotinfo.site_id is -1 in a reclaimed fortress - can we safely mitigate? #5937

Closed
Closed
plotinfo.site_id is -1 in a reclaimed fortress - can we safely mitigate?#5937

Description

@ab9rf
ab9rf
opened on Sep 17, 2026

should we have a tool that forcibly updates plotinfo.site_id when it's found to be -1 in fort mode (as this violates what we believe to be an invariant) as a mitigation of a DF bug - at least until Bay12 fixes it

Originally posted by @ab9rf in #5923 (review)

Activity

  1. Alistair-Afton commented on Sep 17, 2026

    @Alistair-Afton
    Alistair-Afton
    on Sep 17, 2026
    Contributor

    Implemented in #5948: quickfix.repair_site_id() runs from onMapLoad.default.init and restores site_id from plotinfo.main.fortress_site when DF leaves it at -1. It only writes when the invariant is violated and prints a note when it repairs something.

  2. ab9rf commented on Sep 22, 2026

    @ab9rf
    ab9rf
    on Sep 22, 2026
    MemberAuthor

    closed by #5948

  3. ab9rf
    closed this as completedon Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions