Repository navigation
Fix duplicate crafting job dependencies when interfaces re-register - #249
Merged
Merged
Conversation
Crafting interfaces re-register to the network when they become dirty, which added the dependencies of their jobs to the dependency graph again. This caused duplicated subtrees in crafting plans of running jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #248 to 1.20.
When a crafting interface becomes dirty, it unregisters and re-registers to the crafting network.
removeCraftingInterfacekeeps the dependency edges of its jobs, whileaddCraftingInterfaceadds them again, andCraftingJobDependencyGraph.addDependencydid not check for existing edges. Each re-registration therefore duplicated them, which shows up as duplicated subtrees in the plan of a running job.addDependencynow stores each edge (and its reverse link) only once. Covered by unit tests; the game test from #248 is not included since this branch has no game tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y
Generated by Claude Code