Skip to content

2.0 dev bundler regression $comment - #1150

Closed
jkowalleck wants to merge 6 commits into
2.0-devfrom
2.0-dev_bundler-regression-comment
Closed

jkowalleck wants to merge 6 commits into
2.0-devfrom
2.0-dev_bundler-regression-comment

Conversation

@jkowalleck

@jkowalleck jkowalleck commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

bundler currently drops the comment property.

this adds regression tests for this.

this PR is never intended to be merged
it is a showcase, so other PRs might fix the issue.
see the run: https://github.com/CycloneDX/specification/actions/runs/38076673448/job/114285011872?pr=1150#step:5:1767

 test /home/runner/work/specification/specification/tools/src/test/resources/2.0/valid-blueprint-architecture-2.0.json ...
  !!! ERROR: Unexpected validation error 
      schema: /home/runner/work/specification/specification/schema/2.0/cyclonedx-2.0-bundled.min.schema.json 
    for file: /home/runner/work/specification/specification/tools/src/test/resources/2.0/valid-blueprint-architecture-2.0.json 
       error: [
    {
      instancePath: '',
      schemaPath: '#/unevaluatedProperties',
      keyword: 'unevaluatedProperties',
      params: { unevaluatedProperty: '$comment' },
      message: 'must NOT have unevaluated properties',
      schema: false,
      parentSchema: {
        '$schema': 'https://json-schema.org/draft/2020-12/schema',
        '$id': 'https://cyclonedx.org/schema/2.0/cyclonedx-2.0-bundled.min.schema.json',
        type: 'object',
        title: 'CycloneDX Transparency Expression Language',
        '$comment': 'OWASP CycloneDX is an Ecma International standard (ECMA-424) developed in collaboration between the OWASP Foundation and Ecma Technical Committee 54 (TC54). The standard is published under a royalty-free patent policy. This JSON schema is the reference implementation and is licensed under the Apache License 2.0.',
        required: [Array],
        properties: [Object],
        allOf: [Array],
        unevaluatedProperties: false,
        '$defs': [Object]
      },
      data: {
...

this is not a fix, just adds the relevant tests.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added this to the 2.0 milestone Oct 10, 2026
@jkowalleck
jkowalleck requested a review from a team as a code owner October 10, 2026 18:19
@jkowalleck jkowalleck added the chore A chore label Oct 10, 2026
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant