Repository navigation
Initialize empty std::string values with a null terminator - #478
Merged
Merged
Conversation
Co-authored-by: nunoplopes <2998477+nunoplopes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect std::string rule initialization
Initialize empty Oct 7, 2026
std::string values with a null terminator
nunoplopes
marked this pull request as ready for review
October 7, 2026 18:48
joaotgouveia
pushed a commit
to joaotgouveia/cpp2rust
that referenced
this pull request
Oct 27, 2026
…t#478) The `std::string` rules model strings as null-terminated vectors, but default initialization produced an empty vector. Operations such as `length()` then incorrectly assume a terminator exists. - **Type rules:** Initialize default strings with `vec![0]` in both unsafe and refcount models. - **Regression coverage:** Add a default-constructed string case that checks `length()`. ```cpp std::string empty; assert(empty.length() == 0); ``` <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes Cpp2Rust#455 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Nuno Lopes <nuno.lopes@tecnico.ulisboa.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
std::stringrules model strings as null-terminated vectors, but default initialization produced an empty vector. Operations such aslength()then incorrectly assume a terminator exists.vec![0]in both unsafe and refcount models.length().std::stringrule initialization #455