Skip to content

Gatekeep check doesn't actually check for house meeting attendance #455

Closed
#456
Closed
Gatekeep check doesn't actually check for house meeting attendance#455
#456
Labels
buggood first issue

Description

@Qelxiros
Qelxiros
opened on Jan 17, 2026

conditional/conditional/util/member.py

Lines 228 to 231 in 1946a96

.filter(
MemberHouseMeetingAttendance.uid == username,
HouseMeeting.date >= semester_start
)

These lines need to also filter out Absent/Excused house meetings.

Activity

  1. Qelxiros
    added
    bug
    good first issue
    on Jan 17, 2026
  2. BigSpaceships
    linked a pull request that will close this issueMake not slow #456on Jan 17, 2026

  3. EgorShternov2 commented on Jan 17, 2026

    @EgorShternov2
    EgorShternov2
    on Jan 17, 2026

    Hi! I’d like to work on this issue.

    I can open a PR with the fix and add a small test (if applicable) to prevent regression.
    Please let me know if there are any preferred guidelines for this change.

  4. ComputerScienceHouse
    blocked EgorShternov2on Jan 18, 2026
  5. tallen42
    closed this as completedin #456on Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buggood first issue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions