feat(customizer): disable the header and the footer for the whole site

[selul]

Users who build their header and footer with a page builder had no way to turn off the theme header and footer for the whole site. This PR adds Disable Header and Disable Footer to existing Customizer sections, and a disabled header no longer leaves an empty wrapper on the page.

Note

This PR replaces #4628. It carries the commits of #4628 and moves the toggles out of the two single-control sections that #4628 added.

What changed

• Header panel — Disable Header is the first control on the General tab of Global Header Settings. Neve Pro already shows its site-wide header controls on that tab. Sites still on the legacy header builder get the same section with the toggle as a plain control, without tabs.

• Footer panel — a new Footer Options section holds Disable Footer. It sits below the footer rows, after Change Copyright when a site has that section.

• Strings — the change adds no strings to translate. It reuses Disable Header, Disable Footer, Global Header Settings and Footer Options.

• Header markup — when the header is off, the <header> element is printed only if other code adds content around the header, such as the Neve Pro page header. With nothing to wrap, no element is printed. Before, an empty element stayed on the page. The skip link now prints outside the header element, and on AMP it keeps next-page-hide. inc/compatibility/fse.php gets the same change for the block template.

• Post meta — a page can still turn its own header or footer off. A page can no longer turn one back on against the global toggle.

• AMP — the amp-state elements move to neve_after_header_wrapper_hook, because one of them drives the WooCommerce shop sidebar. The scroll-to-top animations print before the header wrapper, and their observer watches an anchor that scrolls out of view. When the footer is off, the infinite scroll steps aside and the archive keeps its regular pagination.

Note

The toggle removes the whole header region, and page builders render into that region. Elementor Pro, Header Footer Elementor and Beaver Themer hook neve_do_header and neve_do_footer, so their headers and footers go away too. This is intended: a user who wants a page builder header leaves the toggle off. Elementor Canvas templates never call get_header(), so they do not change.

Note

The header hooks run inside an output buffer, so the wrapper prints only around real content. A hook callback that calls ob_flush() or throws can bypass that buffer. No callback in Neve or Neve Pro does this.

Note

Disable Header is not a conditional header setting. Neve Pro does not swap it per header layout, so it hides every header layout at once.

What decides if the header renders

flowchart LR
    A["Page loads"] --> B{"Post meta<br/>set to on?"}
    B -- yes --> C["No header"]
    B -- no --> D{"New:<br/>Disable Header<br/>is on?"}:::added
    D -- yes --> E["Changed:<br/>no header element,<br/>skip link stays"]:::changed
    D -- no --> F["Header renders"]

    classDef added fill:#1a7f37,color:#fff,stroke:#116329,stroke-width:3px
    classDef changed fill:#9a6700,color:#fff,stroke:#5c3d00,stroke-width:3px,stroke-dasharray:6 3

Loading

QA

1. Go to WP Admin → Appearance → Customize → Header → Global Header Settings.

   Expect: the General tab opens first and shows Disable Header, off. The Style tab still holds the background controls.

2. Turn on Disable Header and publish. Open the front end in a new tab and view the page source (Ctrl+U or Cmd+Option+U). Search for <header.

   Expect: no match. One neve-skip-link match stays, and Tab at the top of the page shows Skip to content.

3. Open a category archive and a search results page, for example /?s=test.

   Expect: no header on either page. The page metabox never covered these views.

4. Open a single page in the editor. In the sidebar, open Neve Options. Turn Disable Header on, update, then turn it off and update again.

   Expect: with the global toggle on, the page has no header in both states.

5. Turn off the global Disable Header. On the same page, set the page's Disable Header to on and update.

   Expect: this page has no header. Every other page keeps its header.

6. If WooCommerce is active, turn on the global toggle and open the shop archive on a narrow screen.

   Expect: no header. The shop sidebar and its filter toggle still work.

7. Go to WP Admin → Appearance → Customize → Footer → Footer Options. Turn on Disable Footer and publish. Search the front-end source for id="site-footer".

   Expect: no match. The page still ends with </body>.

8. Switch the site to the legacy header builder with WP-CLI, then go to Customize → Header.

   wp theme mod set neve_migrated_builders 0

   Expect: the panel lists Global Header Settings. It holds Disable Header with no tabs, and turning it on removes the header from the preview.

9. Switch the site back to the new builder.

   wp theme mod remove neve_migrated_builders

   Expect: the Header panel shows the builder rows and the tabbed Global Header Settings again.

10. If Neve Pro is active with a license, go to Customize → Header → Global Header Settings → General.

    Expect: Disable Header comes first, above Show This Header Site-wide.

11. If Neve Pro is active with a license, add a component to its Page Header builder. Turn on Disable Header for one page in Neve Options, then for the whole site.

    Expect: in both cases the main header is gone and the page header still shows.

12. If the AMP plugin is active, set the blog to infinite pagination with no sidebar. The Post Pagination control comes from Neve Pro, so without it use WP-CLI. Turn on Disable Footer and open the blog page on its AMP URL.

    wp theme mod set neve_pagination_type infinite
    wp theme mod set neve_default_sidebar_layout full-width

    Expect: the regular page links show at the end of the post list.

Part of #4551.

🤖 Generated with Claude Code

[pirate-bot]

Plugin build for 22e9843 is ready 🛎️!

• Download build

[pirate-bot]

🟡 Changes requested

The toggles move correctly and the tests pass, but two small code fixes are needed in Header.php and the test provider.

Validation details

• Files reviewed: 12/12 changed files. The four PNG screenshots were not inspected.
• TestNeveGlobalHeaderFooter passed at HEAD with PHP 8.3, WordPress 7.1.3 and PHPUnit 9.6: 29 tests, 109 assertions.
• Every changed test failed on the base code with the PR tests kept: 5 failures and 1 error.
• No remaining code references the removed sections or the removed class.
• Capability, sanitization and escaping match the base code.

Untested areas

• The Customizer screens were not opened in a browser. The customizer build was not run.
• The changed Playwright spec was not run.
• Neve Pro was not available, so the order beside its controls is unchecked.

🤖 Automated review · run code-review-agent_6ac6ac6fdea3e6.06896057.

---

🤖 Review agent — review posted ✅ on 9d082a82 · changes requested · 2 findings · 15 min

Run code-review-agent_6ac6ac6fdea3e6.06896057 · trail

[pirate-bot]

🟡 Changes requested

Both earlier findings are fixed. Add native : array return types to the two new helpers in Header.php.

Validation details

• Files reviewed: 12/12 changed files. The four PNG screenshots were not inspected.
• TestNeveGlobalHeaderFooter passed at HEAD with PHP 8.3, WordPress 7.1.3 and PHPUnit 9.6: 29 tests, 109 assertions.
• php -l passed on Header.php.
• Theme Check needs the literal sanitize_callback key inside add_setting(), so the unpacked keys are justified.
• Base-tree test failures and the security checks come from run code-review-agent_6ac6ac6fdea3e6.06896057, not rerun.

Untested areas

• The Customizer screens were not opened in a browser.
• The changed Playwright spec was not run.
• Neve Pro was not available, so the order beside its controls is unchecked.

🤖 Automated review · run code-review-agent_6ac6b18f6f31b7.82482385.

---

🤖 Review agent — review posted ✅ on a66fcdbc · changes requested · 2 findings · 7 min

Run code-review-agent_6ac6b18f6f31b7.82482385 · trail

[pirate-bot]

🟢 Approved

The PR passes. Both helpers in Header.php now declare native : array return types, which fixes the last two findings.

Validation details

• Files reviewed: 12/12 changed files. Only Header.php changed since a66fcdbc. The four PNG screenshots were not inspected.
• php -l passed on Header.php with PHP 8.3.
• TestNeveGlobalHeaderFooter passed at HEAD with PHP 8.3, WordPress 7.1.3 and PHPUnit 9.6: 29 tests, 109 assertions.
• A standards check of the new commit found no issue.
• Security checks and base-tree test runs come from runs code-review-agent_6ac6ac6fdea3e6.06896057 and code-review-agent_6ac6b18f6f31b7.82482385, not rerun.

Untested areas

• The Customizer screens were not opened in a browser.
• The changed Playwright spec was not run.
• Neve Pro was not available, so the order beside its controls is unchecked.

🤖 Automated review · run code-review-agent_6ac6b67b04eaf5.37804121.

---

🤖 Review agent — review posted ✅ on 12ef6887 · approved · 0 findings · 2 min

Run code-review-agent_6ac6b67b04eaf5.37804121 · trail

[pirate-bot]

🟡 Changes requested

The feature code works, but four test fixes are needed: one FSE test cannot fail, one comment is false, one case is missing, and some types are too broad.

Validation details

• Files reviewed: 13/17 changed files. The four PNG screenshots were not inspected.
• TestNeveGlobalHeaderFooter passed at HEAD with PHP 8.3, WordPress 7.1.3 and PHPUnit 9.6: 37 tests.
• With the changed theme files restored from pr-base, 25 of 37 tests failed.
• A scratch FSE render with FSE templates enabled showed the header part dropped only at HEAD.
• Source checks found no security issue.

Untested areas

• The new Playwright spec was not run.
• The Customizer screens were not opened.
• AMP pages were not rendered in a browser.
• Neve Pro was not available.

🤖 Automated review · run code-review-agent_6ac74d64b38553.54222683.

---

🤖 Review agent — review posted ✅ on 70f69bf4 · changes requested · 4 findings · 21 min

Run code-review-agent_6ac74d64b38553.54222683 · trail

[pirate-bot]

🟢 Approved

The PR passes. All four earlier test findings are fixed, and the new commit adds no new problem.

Validation details

• Files reviewed: 13/13 changed files. Since 70f69bf4, only the test file changed and four screenshots were deleted.
• TestNeveGlobalHeaderFooter passed at HEAD with PHPUnit 9.6, PHP 8.3 and WordPress 7.1.3: 37 tests.
• With the changed theme files from pr-base, 25 of 37 tests failed, including the FSE disabled-header and FSE AMP tests.
• With only fse.php from pr-base, 3 FSE tests failed.
• Security checks from run code-review-agent_6ac74d64b38553.54222683 were reused, not rerun. No theme code changed since then.

Untested areas

• The new Playwright spec was not run.
• The Customizer screens and AMP pages were not opened in a browser.
• Neve Pro was not available.

🤖 Automated review · run code-review-agent_6ac753d0713d86.11019970.

---

🤖 Review agent — review posted ✅ on 22e98438 · approved · 0 findings · 7 min

Run code-review-agent_6ac753d0713d86.11019970 · trail