Cape Town | 26-ITP-SEP | Liyema Mfengwana | Sprint 2 | Course-work-2 - #1535
Open
LiyemaMfengwana wants to merge 1 commit into
Open
LiyemaMfengwana wants to merge 1 commit into
LiyemaMfengwana wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LiyemaMfengwana
added
the
Needs Review
LonMcGregor
reviewed
Sep 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work here, it's almost complete. There's one file you could clean up a bit and a stretch that looks unfinished
| lastDotIndex; | ||
|
|
||
| console.log(`The dir part of ${filePath} is ${dir}`); | ||
| console.log(`The ext part of ${filePath} is ${ext}`); |
There was a problem hiding this comment.
This looks like you have repeated some of the code here. Was that intentional? Can you edit this so the code can run?
| // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer | ||
|
|
||
| //No, it will not work perfectly for all values. | ||
| //It does not add leading zeros (so you get 2:5:7 instead of 02:05:07) |
There was a problem hiding this comment.
Well done on finding this edge case
| In the Chrome console, | ||
| invoke the function `alert` with an input string of `"Hello world!"`; | ||
|
|
||
| What effect does calling the `alert` function have? |
There was a problem hiding this comment.
You made changes in this file - did you want to complete this stretch task?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1039
Changelist
complete course work