Cape Town | 26-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls - #1518
RaeesStevens wants to merge 45 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
|
Thank you for your submission. The following are a quick summary of the fixes needed before this PR can be merged. In Form-Controls/index.html, please remove the extra "X" option from the size dropdown so it matches the required 6 options, and add a pattern attribute (pattern=".[^\s].[^\s].*") to the name input to enforce at least two non-space characters. Additionally, improve the form's semantics and accessibility by moving the size dropdown and submit button outside of the color , and update the size label to use for="size". Finally, please fix the typo in Form-Controls/README.md on line 43 ("JavaScrip" -> "JavaScript"). Once these four items are updated, this will be good to go. |
RaeesStevens
left a comment
There was a problem hiding this comment.
Updated with changes from review.
Thank you. I have made changes and submitted for review. Please note update to the title of the PR to 2026. |
cjyuan
left a comment
There was a problem hiding this comment.
- According to https://validator.w3.org/, there are errors in your code. Can you fix them?
Code looks good in general. I only have a few comments and suggestions.
| </div> | ||
|
|
||
| <fieldset> | ||
| <legend>T-shirt color:</legend> | ||
|
|
There was a problem hiding this comment.
Indentation is not consistent.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
| <div class="color-options"> | ||
| <input type="radio" id="blue" name="color" value="blue" required> | ||
| <label for="blue">Blue</label> | ||
|
|
||
| <input type="radio" id="black" name="color" value="black" required> | ||
| <label for="black">Black</label> | ||
|
|
||
| <input type="radio" id="grey" name="color" value="grey" required> | ||
| <label for="grey">Grey</label> | ||
| </div> |
There was a problem hiding this comment.
Could you use an AI tool to find out how the code on lines 35-42 could be simplified?

Cape Town | 25-Sep-ITP | Raees Stevens | Sprint 1 | Form Controls
Self checklist
Task code
CYF-1004
Changelist
Created a form
Added inputs and labels for customer name and email, t-shirt colours and sizes.
Basic form styling using CSS.