Conversation
Enhance setAlarm function to handle input validation, countdown display, and immediate alarm triggering.
Updated the title and structure of the alarm clock HTML.
mrafeie
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
mrafeie
added
📅 Sprint 3
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
mrafeie
added
the
Needs Review
LonMcGregor
reviewed
Sep 21, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, it's almost complete. I have one picky suggestion to look at
|
|
||
| // handle negative input explicitly | ||
| const rawValue = Number(input.value); | ||
| if (rawValue < 0) { |
There was a problem hiding this comment.
This might not be the best way of doing input validation. Is there a way to hint at incorrect inputs that doesn't involve taking over the timer display?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1098
Changelist
Sprint 3 | Alarm Clock
Questions