London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To do List

[mandipsanger]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Task code

CYF-1097

Changelist

Todo list app

[LonMcGregor]

Be careful about your git usage here - this is the todo list task, but you called the branch "alarmclock". Can you resolve that?

Also, did you open this PR before you had fully implemented the task? Can you have another look at the README?

[mandipsanger]

in order to solve this i have to make another branch from main and make a fresh PR. I don't think there is another way I have asked abdi he said thhis shoudl be ok. If you really want me to I can change this and you can review. other wise there is no way i can just change the branch from here unless you know any?

[LonMcGregor]

OK. @mandipsanger if you want to continue on this branch, that's fine. Just keep in mind the need for an appropriate branch name in future.

Could you check and make sure the todo list is complete, then I can review it.

[mandipsanger]

Thank you. ok i will check it it think this. So far it looks ok i will double check the requirements. please check the rest of my things which are complete as I am suppose to finish this before 20 and get badge in order to apply for checkpoint.

[abdishakoor-dev]

This went back to Needs Review on 17 September, but nothing has been pushed to the branch since 9 September. If you made changes locally, they have not reached GitHub yet.

The only change on this PR is in index.html, where "ToDo List" became "To Do List" in the title and the heading. The main feature has not been started.

The README asks for four things under "Main Feature: Mass delete of completed ToDos":

1. A "Delete completed tasks" button in index.html.
2. A deleteCompleted(todoList) function in todos.mjs.
3. A Jest test for it in todos.test.mjs.
4. A call to it in script.mjs when the button is clicked. You should not need to change render().

At the moment todos.mjs exports only the three functions that came with the starter, and todos.test.mjs has only the three starter tests.

You don't need to do anything about the branch name. Léon said on 15 September that carrying on with this branch is fine.

I am setting the label back to Reviewed. Add Needs Review again once the four steps are pushed.