Skip to content

Cape Town | 25-ITP-MAY | Asanda Dunn | Sprint 3 | Alarm Clock - #1449

Open
asandagwala wants to merge 1 commit into
CodeYourFuture:mainfrom
asandagwala:alarmClock
Open

asandagwala wants to merge 1 commit into
CodeYourFuture:mainfrom
asandagwala:alarmClock

Conversation

@asandagwala

@asandagwala asandagwala commented Aug 21, 2026

Copy link
Copy Markdown

TASK ID: CYF-1098

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Worked on the JavaScript code for the alarm clock and all tests passed

@asandagwala asandagwala changed the title Cape Town | 25-ITP-May | Asanda Dunn | Sprint 3 | Alarm Clock Cape Town | 25-ITP-SEP | Asanda Dunn | Sprint 3 | Alarm Clock Sep 15, 2026
@asandagwala asandagwala added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 15, 2026
@asandagwala asandagwala changed the title Cape Town | 25-ITP-SEP | Asanda Dunn | Sprint 3 | Alarm Clock Cape Town | 25-ITP-MAY | Asanda Dunn | Sprint 3 | Alarm Clock Sep 15, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost works, but did you test what happens if you start a timer when one is already counting down?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants