Skip to content

fix(docs): correct maintenance countdown date - #42

Merged
MstfSlm38 merged 1 commit into
26Q2.5from
fix/maintenance-countdown-date
Nov 3, 2026
Merged

MstfSlm38 merged 1 commit into
26Q2.5from
fix/maintenance-countdown-date

Conversation

@MstfSlm38

Copy link
Copy Markdown
Collaborator

Summary

  • Correct the maintenance page date label to 4 Kasım Çarşamba, 17:00.
  • Set the countdown target to 4 November 2026 at 17:00 Türkiye time.

Target branch: 26Q2.5.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T19:10:50.825838Z 12a903e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@MstfSlm38
MstfSlm38 merged commit a3180cc into 26Q2.5 Nov 3, 2026
1 check passed
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review


P2 Badge Remove the nonexistent test gate from releases

Whenever a GitHub release is created, this step runs, but package.json defines no test script. npm test exits with a missing-script error, so the dependent publish-npm job is skipped and no package is published. Add a test script or remove this gate.


"version": "26Q3.5",

P2 Badge Use a semver-valid version for npm publishing

When the npm-publish.yml workflow reaches npm publish, npm rejects 26Q3.5 as an invalid version (npm publish --dry-run returns Invalid version). npm requires versions parseable by node-semver (package.json documentation); the normalization in the separate CI workflow does not affect this release checkout. Use a semver-valid version or normalize it before publishing.


JSON.parse(rawData);

P2 Badge Validate the backup shape before accepting an import

If someone selects syntactically valid JSON that is not a CodeSnip snippet array (for example, {}), this check succeeds and the import handler returns it as valid. The renderer then overwrites all_snippets_data with that value, and subsequent snippet rendering throws when it calls .forEach, leaving the previous collection replaced. Validate the top-level array and expected records before returning success.


pageTitle.innerText = titleMap[category][currentLang];

P2 Badge Add Spanish titles for the fixed categories

When Spanish is selected and the user clicks All or Favorites, this lookup uses currentLang === 'es', but titleMap only defines tr and en; the page heading is therefore set to undefined. Add Spanish values or fall back to an existing translation.


document.body.style.backgroundColor = bgColor;

P2 Badge Let the selected solid color override the theme defaults

When a user chooses a solid background color, this assignment sets the body's inline color, but the added theme rules in style.css force a static background-color with !important. The selected color therefore never takes effect in either theme. Use a theme variable for the setting or remove the overriding declarations.


localStorage.setItem("codesnip_custom_background", String(reader.result));

P2 Badge Account for base64 size and duplicate local storage

For accepted images near the 4 MiB limit, readAsDataURL expands the file, and this value is then stored both under codesnip_custom_background and again in app_settings by applySettings. Larger accepted files can exceed the browser's local-storage quota, causing the save to fail despite passing the size check. Account for the encoded and duplicated size or store the image outside local storage.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant