Skip to content

26 q3.5 - #33

Merged
MstfSlm38 merged 3 commits into
26Q2.5from
26Q3.5
Nov 1, 2026
Merged

MstfSlm38 merged 3 commits into
26Q2.5from
26Q3.5

Conversation

@MstfSlm38

Copy link
Copy Markdown
Collaborator

No description provided.

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

https://github.com/MstfSlm38/CodeSnip/blob/1b1aec7e20f0156c329cd695546941a21bcb1f58/.github/workflows/npm-publish.yml#L19
P2 Badge Remove the nonexistent test step from release publishing

On every GitHub release, this step runs npm test, but package.json defines no scripts.test entry, so npm exits with Missing script: test and the dependent publish-npm job never starts. npm documents that npm test runs the command in scripts.test; remove this step or define a test command (npm test docs).


https://github.com/MstfSlm38/CodeSnip/blob/1b1aec7e20f0156c329cd695546941a21bcb1f58/package.json#L3
P2 Badge Use a SemVer-compatible package version

When the new npm publishing workflow reaches npm publish, it rejects 26Q3.5 as an invalid version; npm publish --dry-run reports Invalid version: "26Q3.5". npm requires the package version to be parseable as SemVer (npm package.json docs).


https://github.com/MstfSlm38/CodeSnip/blob/1b1aec7e20f0156c329cd695546941a21bcb1f58/renderer.js#L228
P2 Badge Re-render category labels when the language changes

When a user changes the language after startup, the category names in the sidebar and new-snippet selector remain in the previous language until restart. These labels are resolved from currentLang only when renderCategories() runs, but applySettings() does not call it.


https://github.com/MstfSlm38/CodeSnip/blob/1b1aec7e20f0156c329cd695546941a21bcb1f58/renderer.js#L547
P2 Badge Provide Spanish titles for the built-in filters

With Spanish selected, clicking All Snippets or Favorites assigns undefined to the page heading because these entries have only tr and en values. Add Spanish values or a fallback for es.


https://github.com/MstfSlm38/CodeSnip/blob/1b1aec7e20f0156c329cd695546941a21bcb1f58/index.html#L283-L284
P2 Badge Remove the duplicate settings controls

This second Liquid Glass control duplicates the setting-glass ID (and the following font-size selector duplicates setting-font-size). Since applySettings() reads the first matching element with getElementById, changing either of these visible duplicate controls has no effect.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MstfSlm38
MstfSlm38 merged commit 52b7a75 into 26Q2.5 Nov 1, 2026
2 of 3 checks passed

This branch had an error being deployed

1 failed deployment
github-pages — 1b1aec7e Deployed Nov 1, 2026 by MstfSlm38 via deploy #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant