Skip to content

Convert byte array to hex: retarget net10.0, ToHexStringLower, namespace fix #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimir-pecanac-main merged 2 commits into from
Sep 22, 2026
Merged

Convert byte array to hex: retarget net10.0, ToHexStringLower, namespace fix #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a6ec0
Convert byte array to hex: retarget net10.0, ToHexStringLower, namesp…
vladimir-pecanac-main Sep 15, 2026
613f32b
Merge branch 'main' into seo/91777-csharp-convert-byte-array-to-hexad…
vladimir-pecanac-main Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...tByteArrayToHex/src/ConvertByteArrayToHexBenchmark/ConvertByteArrayToHexBenchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
<PackageReference Include="CommunityToolkit.HighPerformance" Version="8.2.0" />
<PackageReference Include="BenchmarkDotNet" Version="0.15.8" />
</ItemGroup>

<ItemGroup>
Expand Down
5 changes: 5 additions & 0 deletions ...ByteArrayToHex/src/ConvertByteArrayToHexBenchmark/ConvertByteArrayToHexLowerBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,9 @@ public string ConvertToLowerHexUsingLookupNetStandard20(byte[] source) =>
[ArgumentsSource(nameof(ArrayData))]
public string ConvertToLowerHexUsingConvert(byte[] source) =>
ConversionHelpers.ToHexWithConvert(source, true);

[Benchmark]
[ArgumentsSource(nameof(ArrayData))]
public string ConvertToLowerHexUsingConvertAndToLowerInvariant(byte[] source) =>
Convert.ToHexString(source).ToLowerInvariant();
}
2 changes: 1 addition & 1 deletion ...onvertByteArrayToHex/src/ConvertByteArrayToHexConsole/ConvertByteArrayToHexConsole.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
5 changes: 1 addition & 4 deletions ...ctions-arrays/ConvertByteArrayToHex/src/ConvertByteArrayToHexLibrary/ConversionHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Text;
using ConvertByteArrayHexLibrary;

namespace ConvertByteArrayToHexLibrary;

Expand Down Expand Up @@ -160,8 +159,6 @@ public static unsafe string ToHexWithLookupNetStandard20(byte[] source, bool low

public static string ToHexWithConvert(ReadOnlySpan<byte> source, bool lowercase = false)
{
var result = Convert.ToHexString(source);

return lowercase ? result.ToLowerInvariant() : result;
return lowercase ? Convert.ToHexStringLower(source) : Convert.ToHexString(source);
}
}
2 changes: 1 addition & 1 deletion ...onvertByteArrayToHex/src/ConvertByteArrayToHexLibrary/ConvertByteArrayToHexLibrary.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
2 changes: 1 addition & 1 deletion collections-arrays/ConvertByteArrayToHex/src/ConvertByteArrayToHexLibrary/LookupTables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace ConvertByteArrayHexLibrary;
namespace ConvertByteArrayToHexLibrary;

public static class LookupTables
{
Expand Down
2 changes: 1 addition & 1 deletion ...rtByteArrayToHex/test/ConvertByteArrayToHexUnitTests/ConvertByteArrayLookupTablesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using ConvertByteArrayHexLibrary;
using ConvertByteArrayToHexLibrary;

namespace ConvertByteArrayToHexUnitTests;

Expand Down
10 changes: 5 additions & 5 deletions ...tByteArrayToHex/test/ConvertByteArrayToHexUnitTests/ConvertByteArrayToHexUnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand All @@ -10,13 +10,13 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.0" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="6.0.0">
<PackageReference Include="coverlet.collector" Version="10.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Loading