Repository navigation
fix(observe): report invalid trace encoding without a traceback - #136
Merged
Merged
Conversation
Decode and validate each trace line inside the TraceReadError boundary. Preserve LF, CRLF, CR, Unicode content, blank lines and a valid unterminated last event. Trace, metrics and viz now report invalid UTF-8 as a structured exit-2 error rather than a raw decoding traceback. Fixes #134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid UTF-8 in a trace currently escapes the structured error boundary:
trace,metricsandviz --jsoncrash with empty stdout instead of returning the promised error document. Decode each JSONL line inside theTraceReadErrorboundary so the refusal names the actual 1-based line and retains the original decoding cause.Preserve strict refusal of a corrupt file, valid Unicode content, Unicode blank lines, LF/CRLF/CR line boundaries, and a valid final event without a trailing newline. Add API and CLI regression coverage, document the error behavior, and refresh the selected-test figure.
Validation: 24 cases failed on unmodified main; all 27 new checks now pass. The focused trace/replay/CLI/documentation run passed 256 tests.
ruff check .andgit diff --checkpassed. Paid live tests were excluded.Fixes #134.