You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
Despite the "JWT Support" title, this PR adds no library source changes — the bearer-token API (useBearerTokenAuth, updateBearerToken) already exists. Per issue #3100, it (1) reworks CI so the test-with-cloud job generates a fresh short-lived JWT at run time via a new Python script (.github/scripts/generate_jwt.py) signed with a new JWT_PKEY secret, replacing the stale CLIENT_JWT/JWT_TEST_HOST secrets, and commits the matching public JWKS (.github/jwks.json); (2) rewrites the JWT integration tests in client-v2 (ClientTests.testJWTWithCloud, moved from HttpTransportTests) and jdbc-v2 (ConnectionTest.testJWTWithCloud) to consume JWT_TOKEN from the environment and assert the ephemeral JWT::<subject>::<hash> username; (3) adds JWT documentation across docs/ and docs/clickhouse-docs/.
What this impacts
.github/workflows/build.yml — test-with-cloud job: new Python/JWT-generation steps, secret changes, and its dependency changed from test-jdbc-driver to compile
New CI tooling: .github/scripts/generate_jwt.py, requirements.txt, committed public JWKS
Integration tests only in client-v2 and jdbc-v2 (no main-source changes)
Medium rule fired: GitHub workflow changes in .github/ (build workflow, not the release workflow — so not High).
Test-infra scope: test-with-cloud now depends only on compile instead of test-jdbc-driver, so cloud tests run even if local JDBC tests fail — worth confirming this ordering change is intentional.
New CI secret (JWT_PKEY) introduced and old JWT secrets dropped; tests now silently skip (SkipException) when JWT_TOKEN is unset, so a misconfigured secret would pass CI without exercising JWT auth.
Title/body mismatch: "JWT Support" suggests a feature, but the diff is tests + docs + CI only; the committed JWKS/cert in .github/jwks.json is a public key for the test instance (no private material committed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #3100
Checklist
Delete items not relevant to your PR: