Repository navigation
Ice & Fire RLCraft support - #389
Open
CaliforniaDemise wants to merge 5 commits into
Open
CaliforniaDemise wants to merge 5 commits into
CaliforniaDemise wants to merge 5 commits into
Conversation
WaitingIdly
reviewed
Aug 18, 2026
Rongmario
requested changes
Oct 30, 2026
Rongmario
left a comment
Rongmario
left a comment
Member
There was a problem hiding this comment.
Few changes, but good stuff.
Also, update groovyscript.wiki.iceandfire.lightning_forge.note in the lang file as it still says RotN is required, but this PR enables the lightning forge on the rlcraft edition too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rlcraft edition moves recipe lists to a different class which makes it incompatible with GroovyScript. This PR fixes it adding list parameter to constructor and getting the right field via checking for the version in mods container.