Repository navigation
feat(pgn): add mainline import and export with diagnostics - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PgnGamemodel with tags, initial FEN, coordinate moves and a declared result.Validation
All checks passed: 1,528 tests, no build warnings or errors.
Additional validation:
.nupkgand.snupkgartifacts and validated them withVerify-Package.ps1.Test-PackageConsumer.ps1against the local package.Deep tests were not run. Benchmarks used short in-process runs and do not establish production latency guarantees. The package-consumer check required execution outside the sandbox after a NuGet access-denied failure.
Compatibility and risks
ChessGame.Outcome. Restoration does not infer resignation, timeout or draw-claim details.ToGame()performs two replays; further optimization remains possible.1.1.0; the planned1.2.0bump is a separate step.Checklist