Skip to content

hotfix: emblem issue #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denyrt merged 1 commit into from
Oct 19, 2026
Merged

hotfix: emblem issue #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ publish or create a GitHub Release.

## Package icon

The package embeds `assets/chessrealms-emblem-128.png` as
`chessrealms-emblem-128.png` and references it through `PackageIcon`. This is the
unchanged 128x128 PNG emblem with transparent corners from the
[ChessRealms organization assets](https://github.com/ChessRealms/.github/blob/83657d5120b3ae8c0d2acdb5af59c2c079e7c518/profile/assets/png/chessrealms-emblem-128.png).
The package embeds `assets/chessrealms-avatar-128.png` as
`chessrealms-avatar-128.png` and references it through `PackageIcon`. This is the
unchanged 128x128 PNG avatar with transparent corners from the
[ChessRealms organization assets](https://github.com/ChessRealms/.github/blob/83657d5120b3ae8c0d2acdb5af59c2c079e7c518/profile/assets/png/chessrealms-avatar-128.png).
The local copy makes package builds independent of the branding repository's
availability. `Verify-Package.ps1` checks both the icon metadata and its presence
in the package. Keep those checks in sync if the filename changes.
Expand Down
2 changes: 1 addition & 1 deletion scripts/Verify-Package.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Assert-Equal "Package description" (Get-MetadataValue $package.Nuspec "descripti
Assert-Equal "Package authors" (Get-MetadataValue $package.Nuspec "authors") "ChessRealms"
Assert-Equal "Package project URL" (Get-MetadataValue $package.Nuspec "projectUrl") "https://github.com/ChessRealms/Engine"
Assert-Equal "Package README" (Get-MetadataValue $package.Nuspec "readme") "README.md"
Assert-Equal "Package icon" (Get-MetadataValue $package.Nuspec "icon") "chessrealms-emblem-128.png"
Assert-Equal "Package icon" (Get-MetadataValue $package.Nuspec "icon") "chessrealms-avatar-128.png"

$license = $package.Nuspec.SelectSingleNode("/*[local-name()='package']/*[local-name()='metadata']/*[local-name()='license']")
if ($null -eq $license -or $license.GetAttribute("type") -cne "expression" -or $license.InnerText -cne "MIT") {
Expand Down
Loading