Repository navigation
Validate process-selection confirmation before accepting attachment - #98
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cheat Engine can assign the requested PID before opening its process handle. The SDK previously discarded
openProcess's return value, so a matching PID could be reported as a successful attachment without CE's nonzero-handle confirmation.Require boolean
truebefore checking the selected PID and bitness. Missing or false confirmation returnsSelectionNotConfirmed; malformed confirmation returnsInvalidResult. Update the contract documentation and preserve the existing successful-selection, mismatched-PID and Lua-error cases.Validation: all five new regression cases incorrectly returned success before the fix and passed afterward. All 77 affected-class cases and 751 Engine NativeLua cases passed with zero failures or skips. The complete SDK Release build passed with zero warnings or errors. Rebasing onto the merged callback-cleanup fix left the tested file contents unchanged.
This fixes an independently demonstrated selection invariant. The cause of the observed live file-target restoration failure remains under investigation.