Repository navigation
Reuse the admitted Lua state for synchronized callback cleanup - #97
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronized dispatch cleanup reacquires the host's Lua-state provider even though the original operation and stack frame are still active. Release the callback on that original admitted state so cleanup keeps the same Lua universe and lifecycle lease through frame restoration.
Real Lua coroutine regressions cover successful work, a managed exception and an exact Lua error. They verify one provider acquisition, callback-registry cleanup and restored stack sentinels. The three new cases fail against the previous implementation; all six focused cases pass with the fix.
Validation: Release solution build passed with zero warnings or errors; all 136 hosting tests, 363 Lua tests and 746 engine NativeLua tests passed with zero failures or skips. Independent review found no remaining actionable issue in this patch. The separate intermittent native CE crash investigation remains open; these results establish the cleanup invariant without establishing that crash's cause.