Repository navigation
Verify memory-record parent assignments - #96
Merged
Merged
Conversation
Refuse unsupported root detach before calling the nil setter, verify supported assignments through fresh lookup and parent ID readback, and preserve started failures without retrying. Keep existing outcome enums for Client compatibility. Validation: 20 focused mutation tests, 740 Engine NativeLua tests, formatting, whitespace, and independent Astra review.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cheat Engine can silently ignore a memory-record parent assignment.
AddressListMutations.SetParentpreviously reported completion from the Lua call status alone, so a request to detach a child to the root could claim success while leaving it in its group.Resolve the child again after a parent setter returns and verify its requested parent ID before reporting completion. A missing or malformed postcondition remains indeterminate with a started effect. Never invoke the unsupported nil-parent setter: an already-root record succeeds without mutation, while detaching a nested record reports
GlobalUnavailable/NotAttempted. Existing public enum values preserve compatibility with Client package builds.Regression coverage includes supported parent changes, root no-ops and refusals, silently ignored and wrong assignments, failed parent/ID getters before and after mutation, disappearing records/lists, stack preservation, and rejected reentrant runtime resets. Admission already excludes supported state transitions; the patch retains identity checks before mutation and verified completion without repeating intermediate checks. Validation: 26 focused mutation tests and all 746 Engine NativeLua tests passed in Release with no skips; formatting and whitespace checks passed. The local coverage report hits 62 of 64 changed executable lines (96.88%); CI remains the authoritative quality gate. Independent Astra review found no remaining correctness or assertion issues.
These are standalone Lua tests with host doubles. The MCP integration will run a separate owned-target CE qualification session after consuming the merged source revision.