Skip to content

fix(gpui): follow the macOS Reduce Motion setting - #2714

Open
richiemcilroy wants to merge 1 commit into
mainfrom
fix/gpui-follow-system-reduce-motion
Open

richiemcilroy wants to merge 1 commit into
mainfrom
fix/gpui-follow-system-reduce-motion

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

GPUI keeps its own Reduce Motion flag (App::reduce_motion, false at startup) and never reads the OS setting, and nothing in Cap called set_reduce_motion. So every animation that checks the flag ignored macOS's Accessibility > Display > Reduce motion: with_animation everywhere, the camera window's loading glass, and the onboarding welcome screen (found by Capy on #2713).

On macOS the app now reads NSWorkspace.accessibilityDisplayShouldReduceMotion at startup and updates the flag whenever NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification fires, through a main-queue observer that lives for the app. Windows and Linux are unchanged (no-op).

Effect

With Reduce motion on, GPUI animations render their final frame (GPUI's built-in behaviour for the flag) and Cap's own checks (camera_loading, camera_window, the welcome screen) switch to their reduced paths. With it off (the default), nothing changes.

Testing

  • Startup read logged on macOS 26 with the setting off: system reduce motion reduce=false.
  • Not yet exercised: toggling the setting while Cap runs (needs the real System Settings switch).
  • Clippy clean.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable defects were found.

Summary

The PR makes Cap follow the macOS Reduce Motion setting.

  • The desktop app's animations now follow macOS Reduce Motion.

No actionable issues were found. Live toggling was not verified during this review.

Reviews (2) · Last reviewed commit: "fix(gpui): follow the macOS Reduce Motio..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 19, 2026 5:39pm UTC

@richiemcilroy

Copy link
Copy Markdown
Member Author

@greptileai review

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

This branch was successfully deployed

2 active deployments
Preview – cap-web — 80f0d9a2 Deployed Oct 19, 2026 by vercel[bot]
Preview – cap-status — 80f0d9a2 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant