Repository navigation
fix(gpui): follow the macOS Reduce Motion setting - #2714
Open
richiemcilroy wants to merge 1 commit into
Open
richiemcilroy wants to merge 1 commit into
richiemcilroy wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@greptileai review |
richiemcilroy
marked this pull request as ready for review
October 19, 2026 18:00
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUI keeps its own Reduce Motion flag (
App::reduce_motion, false at startup) and never reads the OS setting, and nothing in Cap calledset_reduce_motion. So every animation that checks the flag ignored macOS's Accessibility > Display > Reduce motion:with_animationeverywhere, the camera window's loading glass, and the onboarding welcome screen (found by Capy on #2713).On macOS the app now reads
NSWorkspace.accessibilityDisplayShouldReduceMotionat startup and updates the flag wheneverNSWorkspaceAccessibilityDisplayOptionsDidChangeNotificationfires, through a main-queue observer that lives for the app. Windows and Linux are unchanged (no-op).Effect
With Reduce motion on, GPUI animations render their final frame (GPUI's built-in behaviour for the flag) and Cap's own checks (
camera_loading,camera_window, the welcome screen) switch to their reduced paths. With it off (the default), nothing changes.Testing
system reduce motion reduce=false.

Confidence Score: 5/5
The PR appears safe to merge; no actionable defects were found.Summary
The PR makes Cap follow the macOS Reduce Motion setting.
No actionable issues were found. Live toggling was not verified during this review.
Reviews (2) · Last reviewed commit: "fix(gpui): follow the macOS Reduce Motio..." · Reviewed by Greptile