Skip to content

Test iterable edge inputs in solid fillet and chamfer - #2107

Open
RanaPriyansh wants to merge 2 commits into
CadQuery:masterfrom
RanaPriyansh:test-iterable-edge-inputs-2104
Open

RanaPriyansh wants to merge 2 commits into
CadQuery:masterfrom
RanaPriyansh:test-iterable-edge-inputs-2104

Conversation

@RanaPriyansh

@RanaPriyansh RanaPriyansh commented Oct 8, 2026 •

Copy link
Copy Markdown

The direct solid methods need iterable-input coverage alongside the Shape-input cases in #2105.
Add six cases for lists and one-use generators in fillet and chamfer, including asymmetric chamfer.
Check valid output geometry, face counts, analytical volumes, and valid, unit-volume input solids.
These tests support #2104.

Sequential Linux validation uses Ubuntu 24.04, Python 3.12.15, and OCP 8.0.1.1:

  • Unchanged master: 898 passed, three skipped.
  • Merged candidate: 904 passed, three skipped, including all six added cases.
  • Full CadQuery Black and Mypy checks pass in both phases.
  • Both phases use the same resolved environment, with only the editable CadQuery path changed.

The upstream AppVeyor matrix passes Black, Mypy, and the complete suite:

  • Windows: 906 passed, one skipped.
  • Linux and macOS: 904 passed, three skipped on each platform.
  • All six added cases pass on each platform.

The Azure Windows 3.13 build also passes.
Both providers tested the PR merge commit, whose tree equals the published candidate tree.
An older Azure check record for that successful build remains queued.

The local macOS baseline volume failure in test_interpPlate remains recorded.

Codex used.

@adam-urbanczyk
adam-urbanczyk marked this pull request as draft October 8, 2026 21:40
@RanaPriyansh

Copy link
Copy Markdown
Author

Merged current master and completed fresh sequential Linux validation.
The baseline passed 898 tests, and the candidate passed 904 tests, with three skips in each phase.
All six added cases, full Black, and Mypy passed.

The macOS baseline still has the recorded test_interpPlate volume failure.
This PR remains a draft pending cross-platform validation and review.

Codex used.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.81%. Comparing base (5f5bc62) to head (2b85056).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2107   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          30       30           
  Lines        9599     9599           
  Branches     1441     1441           
=======================================
  Hits         9197     9197           
  Misses        247      247           
  Partials      155      155           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RanaPriyansh
RanaPriyansh marked this pull request as ready for review October 15, 2026 09:44
@RanaPriyansh

Copy link
Copy Markdown
Author

Marked ready for review after upstream cross-platform validation.
The AppVeyor matrix passes all six added cases on Windows, Linux, and macOS.
Black, Mypy, and the complete suite pass on each platform.
The Azure Windows 3.13 build also passes.

Older Azure check record 116333678107 remains queued for the same successful build 6099.
Please reconcile that record if it is a required merge check.

Codex used.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant